Page MenuHomeFreeBSD

security/py-{acme,certbot}: Update to 0.9.2
ClosedPublic

Authored by cpm on Oct 12 2016, 12:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 10:13 AM
Unknown Object (File)
Sat, Oct 4, 12:27 AM
Unknown Object (File)
Fri, Oct 3, 10:48 PM
Unknown Object (File)
Fri, Oct 3, 8:26 PM
Unknown Object (File)
Fri, Oct 3, 8:18 PM
Unknown Object (File)
Fri, Oct 3, 7:20 AM
Unknown Object (File)
Thu, Oct 2, 7:50 PM
Unknown Object (File)
Thu, Oct 2, 7:28 PM
Subscribers
None

Details

Summary

security/py-{acme,certbot}: Update to 0.9.2

Common:

  • Update PORTVERSION and distinfo checksum (0.9.2)

security/py-acme:

  • Add dns/py-dnspython dependency required to support both Python 2 and Python 3
Test Plan

portlint -ac output looks fine.

poudriere testport logs are fine on 9,3/ia, 10.2/ia and 10.3/ia

make test looks fine.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cpm retitled this revision from to security/py-{letsencrypt,acme}: Update to 0.9.1.
cpm updated this object.
cpm edited the test plan for this revision. (Show Details)
cpm added reviewers: AMDmi3, feld, junovitch, koobs.
cpm retitled this revision from security/py-{letsencrypt,acme}: Update to 0.9.1 to security/py-{acme,certbot}: Update to 0.9.1.
koobs requested changes to this revision.EditedOct 12 2016, 8:34 AM
koobs edited edge metadata.

Code changes LGTM.

Review/Commit log changes needed:

TEST PLAN section is missing QA results:

  • portlint:
  • testport:
  • unittest:

* py-acme: Add new dependency to RUN_DEPENDS is clearer & more explicit in SUMMARY (commit log message)

If these will be committed in one commit, first line of commit should be:

security/py-acme security/py-acme: Update to 0.9.1

Generally speaking, commit logs should be:

category/portname: Change summary

Some optional introduction paraphraph or sentence
establishing context or background

* Itemized change one
* Itemized change two, with necessary explanation [1]
* Do this, because that.

Some optional final words, sentences or paragraphs about impact,
conclusions, caveats, implications, or extra context.

[1] https://SomeExternalReferenceOrLinkLikeABugOrCommit

Use above as the Phabricator review SUMMARY

This revision now requires changes to proceed.Oct 12 2016, 8:34 AM

certbot (and presumably) acme 0.9.2 have been released

cpm retitled this revision from security/py-{acme,certbot}: Update to 0.9.1 to security/py-{acme,certbot}: Update to 0.9.2.
cpm updated this object.
cpm edited edge metadata.
cpm edited edge metadata.
In D8223#171096, @koobs wrote:

certbot (and presumably) acme 0.9.2 have been released

Thanks for letting me know :)

Testing@work after update py-{acme,certbot} to 0.9.2

portlint -ac output looks fine.

poudriere testport logs are fine on 9,3/ia, 10.2/ia and 10.3/ia

make test looks fine.

koobs edited edge metadata.

LGTM. Don't forget to add QA results to the 'TEST PLAN' review section.

This revision is now accepted and ready to land.Oct 13 2016, 12:17 PM
This revision was automatically updated to reflect the committed changes.
cpm edited edge metadata.