Differential D8207

[net80211/wifi bits]: convert all ieee80211_input_mimo*() consumers to ieee80211_add_rx_params() + drop last (ieee80211_rx_stats) parameter
ClosedPublic
Actions

Authored by avos on Oct 9 2016, 9:54 PM.

Details

Reviewers

adrian

Commits

rS307158: net80211: convert all ieee80211_input_mimo*() consumers

Test Plan

Driver-specific part was not tested.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 21212.Oct 9 2016, 9:54 PM

avos retitled this revision from to [net80211/wifi bits]: convert all ieee80211_input_mimo*() consumers to ieee80211_add_rx_params() + drop last (ieee80211_rx_stats) parameter.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added a reviewer: adrian.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 9 2016, 9:54 PM

P.S. is there any need to call memcpy(3) in ieee80211_???_rx_params() ? As I can see, it can return a pointer to ieee80211_rx_params structure instead (NULL if operation fails)

Thanks for this!

This revision is now accepted and ready to land.Oct 11 2016, 12:33 AM

In D8207#170435, @adrian wrote:

Thanks for this!

In D8207#170216, @s3erios_gmail.com wrote:

P.S. is there any need to call memcpy(3) in ieee80211_???_rx_params() ? As I can see, it can return a pointer to ieee80211_rx_params structure instead (NULL if operation fails)

I don't think there's any reason to memcpy() it out. I was just being careful.

If it's not memcpy'ed out then consumers need to ensure they don't hold onto references after any mbuf manipulation that may cause the underlying mbuf to be freed/reallocated.

Closed by commit rS307158: net80211: convert all ieee80211_input_mimo*() consumers (authored by avos). · Explain WhyOct 12 2016, 8:50 PM

This revision was automatically updated to reflect the committed changes.