Page MenuHomeFreeBSD

biology/jellyfish: update to bug-fix release 2.2.6
ClosedPublic

Authored by jrm on Oct 9 2016, 4:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 2:47 AM
Unknown Object (File)
Tue, Sep 23, 12:41 PM
Unknown Object (File)
Sun, Sep 21, 11:21 PM
Unknown Object (File)
Sat, Sep 20, 1:38 AM
Unknown Object (File)
Wed, Sep 17, 11:38 PM
Unknown Object (File)
Sep 16 2025, 5:22 PM
Unknown Object (File)
Sep 16 2025, 1:42 AM
Unknown Object (File)
Sep 10 2025, 11:37 PM

Details

Summary

biology/jellyfish: update to bug-fix release 2.2.6

Test Plan

portlint -AC: OK
testport: OK (poudriere: 9.3-RELEASE-p45, amd64)
testport: OK (poudriere: 10.3-RELEASE-p7, i386)
testport: OK (poudriere: 10.3-RELEASE-p7, amd64)
testport: OK (poudriere: 11.0-RC3, i386)
testport: OK (poudriere: 11.0-RC3, amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm retitled this revision from to biology/jellyfish: update to bug-fix release 2.2.6.
jrm updated this object.
jrm edited the test plan for this revision. (Show Details)
jrm added reviewers: swills, AMDmi3.
AMDmi3 requested changes to this revision.Oct 9 2016, 11:03 PM
AMDmi3 edited edge metadata.

It's better to substitute PORTVRESION in pkg-plist to reduce further diffs. Actually, I don't see why includes are needed to be under jellyfish-${PORTVERSION} since there's only one version of jelly fish in ports, but fixing this will probably complicate the port unnecessarily.

This revision now requires changes to proceed.Oct 9 2016, 11:03 PM
jrm edited edge metadata.

Substitute PORTVERSION in pkg-plist

AMDmi3 edited edge metadata.
This revision is now accepted and ready to land.Oct 10 2016, 10:57 AM
jrm edited edge metadata.

Update after commit to mark this port as broken on aarch64.

This revision now requires review to proceed.Dec 18 2016, 3:45 PM
AMDmi3 edited edge metadata.
AMDmi3 added inline comments.
biology/jellyfish/Makefile
28 ↗(On Diff #23059)

It's better to not use += unless you expect previous value in the variable, and before bsd.port.options.mk or other port's Makefile inclusion, you basically only expect {C,CPP,CXX,LD}FLAGS to be set, so no += is needed for PLIST_SUB, SUB_FILES, SUB_LIST, {MAKE,CONFIGURE,CMAKE etc}_{ARGS,ENV} etc.

This revision is now accepted and ready to land.Dec 19 2016, 4:20 PM
This revision was automatically updated to reflect the committed changes.