Page MenuHomeFreeBSD

[iwm] Remove unused field from iwm_rx_data. Use uint32_t instead of enum type.
ClosedPublic

Authored by ivadasz on Sep 18 2016, 9:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 5:04 AM
Unknown Object (File)
Sep 30 2024, 6:29 PM
Unknown Object (File)
Sep 29 2024, 10:54 PM
Unknown Object (File)
Sep 27 2024, 11:26 AM
Unknown Object (File)
Sep 23 2024, 11:42 PM
Unknown Object (File)
Sep 23 2024, 3:24 AM
Unknown Object (File)
Sep 22 2024, 8:17 AM
Unknown Object (File)
Sep 22 2024, 6:10 AM
Subscribers

Details

Summary

The wantresp field in struct iwm_rx_data has never been used for anything,
so we can just delete it.

Apparently struct iwm_sf_cfg_cmd was compiled correctly (using a 32bit
value to represent the enum), but it still seems like a very bad idea to use
an enum type in a __packed struct.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivadasz retitled this revision from to [iwm] Remove unused field from iwm_rx_data. Use uint32_t instead of enum type..
ivadasz updated this object.
ivadasz added reviewers: adrian, cognet.
adrian edited edge metadata.
This revision is now accepted and ready to land.Sep 19 2016, 9:36 PM
This revision was automatically updated to reflect the committed changes.