Remove last remnants of NO_STAGE.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I'd rather keep the BROKEN bit. Vendors and users using custom ports will need to know their port is broken if they import it from the year period when we had NO_STAGE in there. If it predates that period, oh well. If someone restores an unstaged port and somehow manages to commit it, we still want it to be BROKEN.
I'm sure others will disagree though.
Comment Actions
And in fact, I've imported many deleted ports from the past year into my own ports tree and have not yet had time to stage them. I'm sure I'll forget about the requirement before I find time to build packages again. If this were removed I will be very surprised. It's essentially a POLA argument for me.
Comment Actions
I do think we should keep those remnant for around a year which is the reason I have added them when dropping support.
Comment Actions
My reasoning was that corresponding bits were removed from bpm, so even if user will keep private port, it will fails anyway with easily recognized error.
Ok then, can I remove NO_STAGE condition from devel/ice ?
Comment Actions
Many ports will build and install just fine without STAGEDIR set. Do it from a real server (not poudriere) and you won't even know there is an issue until it's already splatted files all over /.
Comment Actions
Many ports will build and install just fine without STAGEDIR set. Do it from a real server (not poudriere) and you won't even know there is an issue until it's already splatted files all over /.
Hmm, I was under impression, that package is always created before installation.
But it seems that pkg register is used instead. IMO, it's bad optimization.
Comment Actions
Hmm, I was under impression, that package is always created before installation.
But it seems that pkg register is used instead. IMO, it's bad optimization.
No, pkg register also fails with error 74.
Did you mean that bad port can install/remove files to host's fs before pkg invocation?
Yes, NO_STAGE can prevents this from happening in some cases. There is no guarantees that
private port has NO_STAGE at all, though.
Comment Actions
No, I mean what I said. The ports framework will call 'make install' for whatever installer target is set for the port. If the port ignores DESTDIR then it will splatter files over PREFIX. *Then* the framework tries to package it and the user is alerted. It's too late for the files touched on their system though.
Comment Actions
Yup, I have dozens from 2007 at work that don't have it.
There's no harm in keeping the check for a year. It's safer than not for users who may have grabbed a port in the last year, or try to restore something.
Comment Actions
No, I mean what I said. The ports framework will call 'make install' for whatever installer target is set for the port. If the port ignores DESTDIR then it will splatter files over PREFIX. *Then* the framework tries to package it and the user is alerted. It's too late for the files touched on their system though.
That's what I've tried to say. The port can touch host's fs before invocation of package manager. The only way to prevent this is to never build on the host's fs.
Yup, I have dozens from 2007 at work that don't have it.
There's no harm in keeping the check for a year. It's safer than not for users who may have > grabbed a port in the last year, or try to restore something.
I agree, if it helps to prevent mess in some cases, it should stay. Maybe even longer than year.