Page MenuHomeFreeBSD

Propagate error status of /usr/sbin/bhyve out of vmrun.sh script
ClosedPublic

Authored by rodrigc on Sep 12 2014, 2:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 10 2024, 5:38 PM
Unknown Object (File)
Sep 17 2024, 6:33 AM
Unknown Object (File)
Sep 12 2024, 6:45 PM
Unknown Object (File)
Sep 12 2024, 6:44 PM
Unknown Object (File)
Sep 11 2024, 6:25 PM
Unknown Object (File)
Sep 11 2024, 12:54 AM
Unknown Object (File)
Sep 2 2024, 9:00 AM
Unknown Object (File)
Sep 1 2024, 11:24 PM
Subscribers
None

Details

Reviewers
grehan
neel
Summary
  • Propagate the error status of /usr/sbin/bhyve out of the vmrun.sh script
  • clean up the /dev/vmm entry for this VM when vmrun.sh exits

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rodrigc retitled this revision from to Propagate error status of /usr/sbin/bhyve out of vmrun.sh script.
rodrigc updated this object.
rodrigc edited the test plan for this revision. (Show Details)
rodrigc added reviewers: neel, grehan.
vmrun.sh
256 ↗(On Diff #1591)

If bhyve exits because of an error then it is useful to keep /dev/vmm/vm around for post-mortem.

Could you modify this so the vmm device is deleted only for known good exits? For e.g., poweroff, reset etc.

In D767#4, @neel wrote:

If bhyve exits because of an error then it is useful to keep /dev/vmm/vm around for post-mortem.

Could you modify this so the vmm device is deleted only for known good exits? For e.g., poweroff, reset etc.

OK, done.

neel edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Sep 12 2014, 8:07 PM