Page MenuHomeFreeBSD

Invert calloc(3) argument order.
ClosedPublic

Authored by araujo on Aug 16 2016, 3:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 12:03 AM
Unknown Object (File)
Tue, Oct 29, 11:35 PM
Unknown Object (File)
Tue, Oct 29, 10:30 PM
Unknown Object (File)
Tue, Oct 29, 10:30 PM
Unknown Object (File)
Tue, Oct 29, 10:15 PM
Unknown Object (File)
Tue, Oct 29, 6:47 PM
Unknown Object (File)
Tue, Oct 29, 2:08 PM
Unknown Object (File)
Tue, Oct 29, 2:08 PM
Subscribers

Details

Summary

Seemed some calloc(3) calls has its arguments inverted,
by the manpage it should be used nitems and size, and not
the oposite.

As I don't really know the intention of the code, would
like a double check from the maintainer.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

araujo retitled this revision from to Invert calloc(3) argument order..
araujo updated this object.
araujo edited the test plan for this revision. (Show Details)
araujo added a reviewer: trasz.
trasz edited edge metadata.

Looks fine, thanks! Note that those files are duplicated in iscsid(8), so you might also want to fix it there.

This revision is now accepted and ready to land.Aug 17 2016, 10:17 AM
This revision was automatically updated to reflect the committed changes.