Merge ifgroup and interface name namespaces
AbandonedPublic
Actions

Authored by kp on Aug 16 2016, 12:40 PM.

Details

Reviewers

Group Reviewers

Summary

pf allows network interfaces and groups to be used interchangeably. They don't
share a namespace so it's possible for an interface and a group to have the same
name.
Merge the namespaces, because this fixes both the panic in pf and brings us closer to admin expectations.

PR: 127042, 202178

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kp updated this revision to Diff 19337.Aug 16 2016, 12:40 PM

kp retitled this revision from to Merge ifgroup and interface name namespaces.

kp updated this object.

kp edited the test plan for this revision. (Show Details)

kp added reviewers: eri, network.

kp set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptAug 16 2016, 12:40 PM

I'm not very happy with this patch, both for locking reasons and error handling reasons. I'm not sure how to improve it however, and wanted to post it in case people had better ideas.

kp abandoned this revision.May 3 2017, 8:21 PM