Fix some logic in PCIe HotPlug; display EI status
ClosedPublic
Actions

Authored by vangyzen on Aug 5 2016, 10:59 PM.

Details

Reviewers

Commits

rS303788: Fix some logic in PCIe HotPlug; display EI status

Summary

The interpretation of the Electromechanical Interlock Status was
inverted, so we disengaged the EI if a card was inserted.
Fix it to engage the EI if a card is inserted.

When displaying the slot capabilites/status with pciconf:

We inverted the sense of the Power Controller Control bit, saying the power was off when it was really on (according to this bit). Fix that.

Display the status of the Electromechanical Interlock:

EI(engaged)
EI(disengaged)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vangyzen updated this revision to Diff 19080.Aug 5 2016, 10:59 PM

vangyzen retitled this revision from to Fix some logic in PCIe HotPlug; display EI status.

vangyzen updated this object.

vangyzen edited the test plan for this revision. (Show Details)

vangyzen added a reviewer: jhb.

Herald added a subscriber: imp. · View Herald TranscriptAug 5 2016, 10:59 PM

jhb accepted this revision.Aug 5 2016, 11:05 PM

jhb edited edge metadata.

This revision is now accepted and ready to land.Aug 5 2016, 11:05 PM

Closed by commit rS303788: Fix some logic in PCIe HotPlug; display EI status (authored by vangyzen). · Explain WhyAug 5 2016, 11:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

pci/

pci_pci.c

8 lines

usr.sbin/

pciconf/

cap.c

5 lines

Diff 19081

View Options

head/sys/dev/pci/pci_pci.c