Include src.opts.mk after SHLIBDIR has been defined so libnv is installed to /lib , not /usr/lib

[ngie]

Summary

Include src.opts.mk after SHLIBDIR has been defined so libnv is installed to /lib , not /usr/lib

MFC after: 3 days

[rpaulo]

This looks fine, but I wonder if it would be better to set SHLIBDIR=/lib without the '?' modifier.

[ngie]

In D739#3, @rpaulo wrote:

This looks fine, but I wonder if it would be better to set SHLIBDIR=/lib without the '?' modifier.

SHLIBDIR?= is the predominant pattern in lib/ :/...

$ grep -r LIBDIR= lib
lib/atf/Makefile.inc:CFLAGS+=   -DATF_LIBDIR='"${LIBDIR}"'
lib/libiconv_modules/Makefile.inc:SHLIBDIR= /usr/lib/i18n
lib/libiconv_modules/Makefile.inc:SHLIBDIR= /usr/lib32/i18n
lib/libiconv_modules/Makefile.inc:LIBDIR=        ${SHLIBDIR}
$ grep -r 'LIBDIR?=' lib                                                                                                                                           
lib/libedit/Makefile:SHLIBDIR?= /lib
lib/ncurses/ncurses/Makefile:SHLIBDIR?= /lib
lib/libufs/Makefile:SHLIBDIR?= /lib
lib/libthr/Makefile:SHLIBDIR?= /lib
lib/libkvm/Makefile:SHLIBDIR?= /lib
lib/libmd/Makefile:SHLIBDIR?= /lib
lib/libdevstat/Makefile:SHLIBDIR?= /lib
lib/libutil/Makefile:SHLIBDIR?= /lib
lib/libjail/Makefile:SHLIBDIR?= /lib
lib/libkiconv/Makefile:SHLIBDIR?=       /lib
lib/libcrypt/Makefile:SHLIBDIR?=        /lib
lib/libcasper/Makefile:SHLIBDIR?=       /lib
lib/libexpat/Makefile:SHLIBDIR?=        /lib
lib/libbegemot/Makefile:SHLIBDIR?= /lib
lib/libnv/Makefile:SHLIBDIR?= /lib
lib/libgeom/Makefile:SHLIBDIR?= /lib
lib/msun/Makefile:SHLIBDIR?= /lib
lib/libsbuf/Makefile:SHLIBDIR?=         /lib
lib/libcam/Makefile:SHLIBDIR?=  /lib
lib/libcapsicum/Makefile:SHLIBDIR?=     /lib
lib/libulog/Makefile:SHLIBDIR?=/lib
lib/libc/Makefile:SHLIBDIR?= /lib
lib/libpcap/Makefile:SHLIBDIR?= /lib
lib/libalias/libalias/Makefile:SHLIBDIR?= /lib
lib/libalias/modules/Makefile.inc:SHLIBDIR?= /lib
lib/libipsec/Makefile:SHLIBDIR?= /lib
lib/libcxxrt/Makefile:SHLIBDIR?=        /lib
lib/libz/Makefile:SHLIBDIR?=    /lib
lib/libpjdlog/Makefile:SHLIBDIR?=       /lib

I agree that explicitly setting LIBDIR makes more sense, but I need to do some digging first to determine whether or not that breaks anything.

[ngie]

Committed as r271241 -- thanks!