Store the offset of the KDOORBELL and GTS registers in the softc.
ClosedPublic
Actions

Authored by jhb on Aug 1 2016, 9:19 PM.

Details

Reviewers

Commits

rS303647: Store the offset of the KDOORBELL and GTS registers in the softc.

Summary

Store the offset of the KDOORBELL and GTS registers in the softc.

VF devices use a different register layout than PF devices. Storing
the offset in a value in the softc allows code to be shared between the
PF and VF drivers.

Test Plan

compiled and booted a kernel and verified ping still works

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 18945.Aug 1 2016, 9:19 PM

jhb retitled this revision from to Store the offset of the KDOORBELL and GTS registers in the softc..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: np.

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2016, 9:19 PM

All egress queues including freelists use the BAR2 doorbell (aka UDB) and not the KDOORBELL by default. You might have to manually remove the setbit(&sc->doorbells, DOORBELL_UDB) in map_bar_2 to test this change for egress queues. See sysctl dev.t5nex.0.doorbells for the doorbells available to the driver.

This revision is now accepted and ready to land.Aug 1 2016, 9:40 PM

Closed by commit rS303647: Store the offset of the KDOORBELL and GTS registers in the softc. (authored by jhb). · Explain WhyAug 1 2016, 10:40 PM

This revision was automatically updated to reflect the committed changes.