Differential D7324

[iwm] Set different pm_timeout for action frames.
ClosedPublic
Actions

Authored by ivadasz on Jul 26 2016, 9:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 6, 12:31 AM

	Unknown Object (File)
	Sat, May 2, 6:26 PM

	Unknown Object (File)
	Apr 13 2026, 3:20 AM

	Unknown Object (File)
	Apr 11 2026, 10:32 PM

	Unknown Object (File)
	Apr 11 2026, 8:28 PM

	Unknown Object (File)
	Apr 6 2026, 9:17 AM

	Unknown Object (File)
	Apr 5 2026, 4:58 PM

	Unknown Object (File)
	Apr 4 2026, 12:32 PM

Subscribers

Details

Reviewers

cognet
sbruno
adrian

Commits

rS303416: [iwm] Set different pm_timeout for action frames.

Summary

When building a Tx Command for management frames, we are lacking
a check for action frames, for which we should set a different
pm_timeout.  This cause the fw to stay awake for 100TU after each
such frame is transmitted, resulting an excessive power consumption.

Taken-From: Linux iwlwifi (git b084a35663c3f1f7)

Obtained from: DragonFlyBSD git ba00f0e3ae873d6f0d5743e22c3ebc49c44dfdac

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivadasz updated this revision to Diff 18778.Jul 26 2016, 9:48 PM

ivadasz retitled this revision from to [iwm] Set different pm_timeout for action frames..

ivadasz updated this object.

ivadasz edited the test plan for this revision. (Show Details)

ivadasz added reviewers: adrian, cognet, sbruno.

Herald added a subscriber: imp. · View Herald TranscriptJul 26 2016, 9:48 PM

Approved.

Just make sure you quote linux/dragonflybsd commit hashes in Obtained From: . you can have >1 obtained from line, eg:

Obtained from: Linux <git>
Obtained from: dragonflybsd <git>

This revision is now accepted and ready to land.Jul 26 2016, 10:21 PM

Closed by commit rS303416: [iwm] Set different pm_timeout for action frames. (authored by ivadasz). · Explain WhyJul 27 2016, 8:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

iwm/

13 lines

12 lines

Diff 18825

head/sys/dev/iwm/if_iwm.c

Loading...

head/sys/dev/iwm/if_iwmreg.h

Loading...