Add new port databases/sqlitebrowser-qt5 as slaveport of databases/sqlitebrowser

[tcberner]

Summary

As suggested by Kubilay in Comment #2 of pr 211217 [1] rather than using an option to decide which toolkit to link against, provide both via slaveports.

I opted to not rename the existing port to sqlitebrowser-qt4 [to reduce the changes] -- even though that might be cleaner.

[1] pr211217

Test Plan

Tested in poudriere / system.

[mat]

Also, when uploading diff manually, use svn diff --diff-cmd=diff -x -U9999 for svn so that the context can be expanded in the web ui. (and git diff -U9999 for git)

databases/sqlitebrowser/Makefile

22

You could check if PKGNAMESUFFIX is empty, or not, and get rid of TOOLKIT_SLAVE.

26

This could go up and be CONFLICTS_INSTALL?=

Also, this could be ${PORTNAME}-qt5-*

[tcberner]

Add updated diff.

• Got rid of TOOLKIT, using PKGNAMESUFFIX
• Moved CONFLICTS_INSTALL?= up

[tcberner]

marked changes done.

[mat]

databases/sqlitebrowser-qt5/Makefile

6

This can be =

databases/sqlitebrowser/Makefile

8–9

This should be ?=

36–37

This is a gnome thing, and this is a QT port.

40

That could be removed.

[tcberner]

• Switch the PORTREVISION ?=/=
• Remove INSTALLS_ICONS
• Remove @echo

[tcberner]

marke comments done.

[mat]

databases/sqlitebrowser-qt5/Makefile

11

There could be an empty line above.

[riggs]

In D7253#151039, @tcberner wrote:

• Remove INSTALLS_ICONS

The port does install icons. Shouldn't this one be kept?

[mat]

In D7253#159345, @riggs wrote:

In D7253#151039, @tcberner wrote:

• Remove INSTALLS_ICONS

The port does install icons. Shouldn't this one be kept?

INSTALLS_ICONS is a USES=gnome thing.