Page MenuHomeFreeBSD
Differential D719

Avoid ./ in zoneinfo entries in METALOG
ClosedPublic
Actions

Authored by emaste on Sep 3 2014, 6:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 9:39 PM
Unknown Object (File)
Tue, Nov 19, 5:05 PM
Unknown Object (File)
Tue, Nov 19, 3:45 PM
Unknown Object (File)
Tue, Nov 19, 3:11 PM
Unknown Object (File)
Tue, Nov 19, 12:24 PM
Unknown Object (File)
Tue, Nov 19, 8:22 AM
Unknown Object (File)
Oct 6 2024, 12:06 AM
Unknown Object (File)
Sep 25 2024, 11:58 PM
View All Files
Subscribers
None

Details

Reviewers
brooks
Commits
rS271047: Avoid ./ in zoneinfo entries in METALOG
Summary

The zoneinfo Makefile's use of find . results in METALOG entries like /path/to/destdir/./America/Toronto, which can upset makefs.

Rely on globbing via find * first to remove the extra ./

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 1350.Sep 3 2014, 6:12 PM
emaste retitled this revision from to Avoid ./ in zoneinfo entries in METALOG.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: brooks.
emaste added a comment.Sep 3 2014, 6:16 PM

Err, I mean an entry like ./usr/share/zoneinfo/./America/Toronto
DESTDIR does not appear in the METALOG, of course.

brooks accepted this revision.Sep 3 2014, 6:30 PM
brooks edited edge metadata.

Looks good to me. I'd been wondering where these errors came from.

This revision is now accepted and ready to land.Sep 3 2014, 6:30 PM
emaste closed this revision.Sep 3 2014, 6:52 PM
emaste updated this revision to Diff 1351.

Closed by commit rS271047 (authored by @emaste).

Revision Contents
Changeset List

PathSize
head/
share/
zoneinfo/
2 lines

Diff 1351

View Options

head/share/zoneinfo/Makefile

Loading...