security/heimdal: Remove EGD
Needs ReviewPublic
Actions

Authored by brnrd on Jul 2 2016, 12:38 PM.

Details

Reviewers

Summary

security/heimdal: Remove EGD

  - Backport EGD removal from upstream 1.6 branch
  - Move from USE_OPENSSL to USES=ssl
  - Use target-OPT for CRACKLIB option

PR:		198527
Reviewed_by:	hrs (maintainer)
Approved by:	(maintainer)
Differential_Revision:	D7053

Test Plan

poudriere testport
portlint -AC

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4395
Build 4445: arc lint + arc unit

Event Timeline

brnrd updated this revision to Diff 18072.Jul 2 2016, 12:38 PM

brnrd retitled this revision from to security/heimdal: Remove EGD.

brnrd updated this object.

brnrd edited the test plan for this revision. (Show Details)

Herald added a subscriber: mat. · View Herald TranscriptJul 2 2016, 12:38 PM

brnrd updated this object.Jul 2 2016, 12:40 PM

brnrd added a reviewer: hrs.

igor.arabesc.pavlov_phabricator_gmail.com added a subscriber: igor.arabesc.pavlov_phabricator_gmail.com.Sep 7 2016, 11:21 PM

igor.arabesc.pavlov_phabricator_gmail.com added inline comments.

security/heimdal/files/patch-Remove-EGD-1.6
420	imho, there's missing minus sign

igor.arabesc.pavlov_phabricator_gmail.com added inline comments.Sep 7 2016, 11:59 PM

security/heimdal/files/patch-Remove-EGD-1.6

420

it should look like this:

@@ -62,22 +62,8 @@ seed_something(void)
     /* Calling RAND_status() will try to use /dev/urandom if it exists so
        we do not have to deal with it. */
     if (RAND_status() != 1) {
-#ifndef _WIN32
-       krb5_context context;
-       const char *p;
-
-       /* Try using egd */
-       if (!krb5_init_context(&context)) {
-           p = krb5_config_get_string(context, NULL, "libdefaults",
-                                      "egd_socket", NULL);
-           if (p != NULL)
-               RAND_egd_bytes(p, ENTROPY_NEEDED);
-           krb5_free_context(context);
-       }
-#else
        /* TODO: Once a Windows CryptoAPI RAND method is defined, we
           can use that and failover to another method. */
-#endif
     }

     if (RAND_status() == 1)    {