Page MenuHomeFreeBSD

Fix invalid enqueue of NULL in bxe tx path
ClosedPublic

Authored by rstone on Jun 30 2016, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 7:21 AM
Unknown Object (File)
Thu, Oct 2, 6:28 PM
Unknown Object (File)
Sat, Sep 20, 12:01 AM
Unknown Object (File)
Aug 12 2025, 11:41 PM
Unknown Object (File)
Aug 8 2025, 7:14 AM
Unknown Object (File)
Jul 29 2025, 9:42 AM
Unknown Object (File)
Jul 27 2025, 8:23 PM
Unknown Object (File)
Jul 27 2025, 12:21 PM
Subscribers

Details

Summary

bxe could incorrectly enqueue NULL on its buf_ring. Most places
in the driver explicitly test for this case and skip it the enqueue
when the mbuf, but one case missed it.

Test Plan

With INVARIANTS enabled, ran a test that stressed the tx path. Under
an overload condition NULL could be enqueued twice to the buf_ring,
leading to an kassert firing.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rstone retitled this revision from to Fix invalid enqueue of NULL in bxe tx path.
rstone updated this object.
rstone edited the test plan for this revision. (Show Details)
rstone added a reviewer: davidcs.
This revision was automatically updated to reflect the committed changes.