libcxxrt: correct mangled "typeinfo name" symbols in Version.map
ClosedPublic
Actions

Authored by emaste on Jun 28 2016, 6:13 PM.

Details

Reviewers

dim
theraven

Commits

rS302278: libcxxrt: correct mangled "typeinfo name" symbols in Version.map

Summary

rS260553 added missing C++ typinfos to libcxxrt's version script. It appears that a number of duplicate mangled symbols were added due to a cut and paste error. Switch the second instances to _ZTS*, typeinfo name for *

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 17988.Jun 28 2016, 6:13 PM

emaste retitled this revision from to libcxxrt: correct mangled "typeinfo name" symbols in Version.map.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: theraven, dim.

emaste updated this object.

Yes, this looks good to me. How did this get noticed, btw?

This revision is now accepted and ready to land.Jun 28 2016, 9:42 PM

I found it while trying to link FreeBSD with lld, which reported an error (now changed to a warning): http://reviews.llvm.org/D21781. lld's symver support is now nearly usable for FreeBSD's needs.

Closed by commit rS302278: libcxxrt: correct mangled "typeinfo name" symbols in Version.map (authored by emaste). · Explain WhyJun 29 2016, 11:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libcxxrt/

Version.map

16 lines

Diff 18006

View Options

head/lib/libcxxrt/Version.map

libcxxrt: correct mangled "typeinfo name" symbols in Version.mapClosedPublicActions