Page MenuHomeFreeBSD
Differential D6958

net80211: fix LOR in ieee80211_ff_node_cleanup()
ClosedPublic
Actions

Authored by avos on Jun 24 2016, 5:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 7:41 PM
Unknown Object (File)
Jan 26 2025, 9:18 PM
Unknown Object (File)
Jan 26 2025, 11:56 AM
Unknown Object (File)
Jan 21 2025, 8:31 PM
Unknown Object (File)
Jan 3 2025, 2:29 PM
Unknown Object (File)
Dec 24 2024, 7:52 AM
Unknown Object (File)
Nov 29 2024, 1:06 PM
Unknown Object (File)
Nov 28 2024, 8:44 AM
View All 63 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS302283: net80211: fix LOR/deadlock in ieee80211_ff_node_cleanup().
Summary

Add new lock for stageq (part of ieee80211_superg structure) and ni_tx_superg (part of ieee80211_node structure); drop com_lock protection where it is used.
While here, drop duplicate OPACKETS counter incrementation.

ni_tx_ampdu is not protected with it (however, it is also used without locking in other places; probably, it requires some other solution to be thread-safe).

Since this change breaks KBI, it will not be merged into 11.0-RELEASE.

Test Plan

Tested with RTL8188CUS (AP) and RTL8188EU (STA).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos updated this revision to Diff 17863.Jun 24 2016, 5:43 PM
avos retitled this revision from to net80211: fix LOR in ieee80211_ff_node_cleanup().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJun 24 2016, 5:43 PM
avos updated this object.Jun 24 2016, 5:47 PM
Closed by commit rS302283: net80211: fix LOR/deadlock in ieee80211_ff_node_cleanup(). (authored by avos). · Explain WhyJun 29 2016, 5:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net80211/
2 lines
19 lines
38 lines
65 lines
1 line

Diff 18018

View Options

head/sys/net80211/ieee80211_ddb.c

Loading...
View Options

head/sys/net80211/ieee80211_freebsd.h

Loading...
View Options

head/sys/net80211/ieee80211_superg.h

Loading...
View Options

head/sys/net80211/ieee80211_superg.c

Loading...
View Options

head/sys/net80211/ieee80211_var.h

Loading...