Differential D6958

net80211: fix LOR in ieee80211_ff_node_cleanup()
ClosedPublic
Actions

Authored by avos on Jun 24 2016, 5:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Feb 27 2024, 10:26 AM

	Unknown Object (File)
	Feb 27 2024, 10:13 AM

	Unknown Object (File)
	Feb 17 2024, 10:33 PM

	Unknown Object (File)
	Feb 15 2024, 11:58 AM

	Unknown Object (File)
	Dec 20 2023, 2:08 AM

	Unknown Object (File)
	Oct 3 2023, 4:47 PM

	Unknown Object (File)
	Sep 22 2023, 4:54 PM

	Unknown Object (File)
	Sep 13 2023, 4:26 PM

View All 40 Files

Subscribers

Details

Reviewers

Commits

rS302283: net80211: fix LOR/deadlock in ieee80211_ff_node_cleanup().

Summary

Add new lock for stageq (part of ieee80211_superg structure) and ni_tx_superg (part of ieee80211_node structure); drop com_lock protection where it is used.
While here, drop duplicate OPACKETS counter incrementation.

ni_tx_ampdu is not protected with it (however, it is also used without locking in other places; probably, it requires some other solution to be thread-safe).

Since this change breaks KBI, it will not be merged into 11.0-RELEASE.

Test Plan

Tested with RTL8188CUS (AP) and RTL8188EU (STA).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 17863.Jun 24 2016, 5:43 PM

avos retitled this revision from to net80211: fix LOR in ieee80211_ff_node_cleanup().

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added a reviewer: adrian.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJun 24 2016, 5:43 PM

avos updated this object.Jun 24 2016, 5:47 PM

Closed by commit rS302283: net80211: fix LOR/deadlock in ieee80211_ff_node_cleanup(). (authored by avos). · Explain WhyJun 29 2016, 5:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

net80211/

ieee80211_ddb.c

2 lines

ieee80211_freebsd.h

19 lines

ieee80211_superg.h

38 lines

ieee80211_superg.c

65 lines

ieee80211_var.h

1 line

Diff 18018

head/sys/net80211/ieee80211_ddb.c

Loading...

head/sys/net80211/ieee80211_freebsd.h

Loading...

head/sys/net80211/ieee80211_superg.h

Loading...

head/sys/net80211/ieee80211_superg.c

Loading...

head/sys/net80211/ieee80211_var.h

Loading...