Python3 specific version for www/py-requests
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
why is this port called py3-requests? the prefix for python ports should just be py-. The package will automatically be named to py31, 32, 33, 34, etc. I understand that this only supports python 3.x, but we still name the ports py-* unless there has been a policy change I'm unaware of.
What do you suggest to do in this case?
Add www/py-request to RUN_DEPENDS and discard www/py3-requests
or
Commit www/py3-requests as a new port (we actually have some py3- ports into the ports tree, like py3-chardet port)
I need to consult with someone who has more knowledge of python ports. I'm going to consult the handbook and see if anything is in there... also Mk/Uses/python.mk ... then maybe a portmgr. Sorry, just want this to be correct.
OK, I agree with you.
At least, they aren't duplicate and the packages builders will work:
% make -C www/py-requests -VPKGNAME
py27-requests-2.10.0
% make -C www/py3-requests -VPKGNAME
py34-requests-2.10.0
Python ports MUST be named py-<name> by default, unless there is a compelling case not to do so.
https://wiki.freebsd.org/Python/PortsPolicy
so let's keep it py-* not py3-*
We don't want to duplicate the existing py-requests port when we do this. Take a look at https://svnweb.FreeBSD.org/ports/head/graphics/py3-pillow/ and note that port just uses this along with a few additional statements to set the correct things that are different from the master port. Please adjust this submission to mirror this.
MASTERDIR= ${.CURDIR}/../py-pillowI suspect when VARIANTS happens the py3-* ports will go away but a python@ person would be useful to ask on that for the long term plans.
End users can do DEFAULT_VERSIONS and get all Python 3 ports but without VARIANTS the only way a pkg only user can get the Python 3 ports is with the py3-* versions.