Page MenuHomeFreeBSD

Add DOCS, EXAMPLES, JAVA and PERL options to devel/staf
ClosedPublic

Authored by asomers on Jun 21 2016, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 12:13 AM
Unknown Object (File)
Jan 17 2024, 2:45 PM
Unknown Object (File)
Jan 10 2024, 5:07 AM
Unknown Object (File)
Dec 30 2023, 4:24 AM
Unknown Object (File)
Dec 30 2023, 4:24 AM
Unknown Object (File)
Dec 30 2023, 4:23 AM
Unknown Object (File)
Dec 30 2023, 4:23 AM
Unknown Object (File)
Dec 30 2023, 4:23 AM
Subscribers

Details

Summary

devel/staf/Makefile
Add options for DOCS, EXAMPLES, JAVA and PERL. The JAVA option
enables all JAVA-based STAF services that don't have additional
dependencies. Also add a symlink from FmtLog to fmtlog.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers retitled this revision from to Add DOCS, EXAMPLES, JAVA and PERL options to devel/staf.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added reviewers: skozlov, brd.

These changes mostly came from Sergey's git repo, but I added more Java services and changed the way that DOCS are installed.

devel/staf/Makefile
172 ↗(On Diff #17740)

Should this be wrapped in parentheses since your a changing the working directory? Or even just be changed to something like?

${COPYTREE_SHARE} ${INSTALL_WRKSRC}/docs/* ${STAGEDIR}${DOCSDIR}
devel/staf/Makefile
172 ↗(On Diff #17740)

The second form doesn't work, because it installs the files with their full paths to the destination directory. I'll fix all COPYTREE commands to use parenthesis.

Use parens when switching directories, and fix the install directory of the docs

Could you please add some poudriere and portlint logs to the review?

The main reason why I didn't upstream the changes was that I couldn't invest time to make a proper testing beforehand.

asomers edited edge metadata.

Add the output of "portlint -A".

@brd, I don't know how to build this in poudriere. Are you setup to do that?

Fix install when DOCS is on but JAVA, PERL, and PYTHON are off. Add poudriere
logs.

  • Please add the logs separately, they must not be a part of the revision
  • Please fix the poudriere warning: "USE_OPENSSL is deprecated, please use USES=ssl"
In D6910#149819, @kozlov.sergey.404_gmail.com wrote:
  • Please add the logs separately, they must not be a part of the revision

How do you add logs to Phabricator if not as part of the revision?

  • Please fix the poudriere warning: "USE_OPENSSL is deprecated, please use USES=ssl"

Ok.

Just drag them to the comment window or use the "Upload file" button

Remove log files from review

devel/staf/Makefile
60 ↗(On Diff #18433)

This fixes the openssl warning

skozlov edited edge metadata.
This revision is now accepted and ready to land.Jul 15 2016, 11:12 PM

Thank you for all the work you've done. Please go ahead and commit it.

This revision was automatically updated to reflect the committed changes.