devel/staf/Makefile
Add options for DOCS, EXAMPLES, JAVA and PERL. The JAVA option
enables all JAVA-based STAF services that don't have additional
dependencies. Also add a symlink from FmtLog to fmtlog.
Details
Details
- Reviewers
brd skozlov - Commits
- rP418611: Add DOCS, EXAMPLES, JAVA and PERL options to devel/staf
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
These changes mostly came from Sergey's git repo, but I added more Java services and changed the way that DOCS are installed.
devel/staf/Makefile | ||
---|---|---|
172 ↗ | (On Diff #17740) | Should this be wrapped in parentheses since your a changing the working directory? Or even just be changed to something like? ${COPYTREE_SHARE} ${INSTALL_WRKSRC}/docs/* ${STAGEDIR}${DOCSDIR} |
devel/staf/Makefile | ||
---|---|---|
172 ↗ | (On Diff #17740) | The second form doesn't work, because it installs the files with their full paths to the destination directory. I'll fix all COPYTREE commands to use parenthesis. |
Comment Actions
Could you please add some poudriere and portlint logs to the review?
The main reason why I didn't upstream the changes was that I couldn't invest time to make a proper testing beforehand.
Comment Actions
- Please add the logs separately, they must not be a part of the revision
- Please fix the poudriere warning: "USE_OPENSSL is deprecated, please use USES=ssl"
Comment Actions
How do you add logs to Phabricator if not as part of the revision?
- Please fix the poudriere warning: "USE_OPENSSL is deprecated, please use USES=ssl"
Ok.