Page MenuHomeFreeBSD

Conditionalize build of etcupdate(8) on MK_RCS.
ClosedPublic

Authored by asomers on Aug 26 2014, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 5:16 PM
Unknown Object (File)
Sat, Jan 18, 6:32 PM
Unknown Object (File)
Fri, Jan 17, 5:34 PM
Unknown Object (File)
Jan 8 2025, 1:20 PM
Unknown Object (File)
Jan 1 2025, 5:53 AM
Unknown Object (File)
Dec 29 2024, 11:57 PM
Unknown Object (File)
Dec 26 2024, 5:53 PM
Unknown Object (File)
Dec 12 2024, 10:11 AM
Subscribers
None

Details

Reviewers
jhb
Summary

Conditionalize build of etcupdate(8) on MK_RCS. Since etcupdate calls
merge(1), which is part of the RCS package, it must not be installed if
WITHOUT_RCS update is set. Otherwise, it will produce confusing errors.

Test Plan

$ WITHOUT_RCS=1 make buildworld
$ WITHOUT_RCS=1 make installworld
$ WITHOUT_RCS=1 make delete-old
<Check that there is no /usr/sbin/etcupdate>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

asomers retitled this revision from to Conditionalize build of etcupdate(8) on MK_RCS..
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: jhb.
tools/build/mk/OptionalObsoleteFiles.inc
3800

There's an etcupdate manpage as well.

Huh, the latest update dropped the changes to stop installing it and now only shows the OptionalObsoleteFiles.inc change. Is that just arc getting confused?

In D691#6, @jhb wrote:

Huh, the latest update dropped the changes to stop installing it and now only shows the OptionalObsoleteFiles.inc change. Is that just arc getting confused?

Yes, that's just arc confusion. Maybe it's because when I did the "arc diff --update D691 [path]" command, I didn't include the unchanged files in the path. I only included the files that had changed since I created the review. I'll try updating the review a third time.

asomers edited edge metadata.

Attempt to get arc to show all changed files. This diff does not represent any actual code changes; just review content changes.

jhb edited edge metadata.

Yes, it is apparently a "feature" of arc that it only uploads the files you list, and if you don't explicitly list them, it uploads every diff in your checkout. I find this particular misfeature a bit annoying compared to other systems that let you edit the list of files to upload interactively.

This revision is now accepted and ready to land.Sep 10 2014, 6:32 PM