Conditionalize build of etcupdate(8) on MK_RCS. Since etcupdate calls
merge(1), which is part of the RCS package, it must not be installed if
WITHOUT_RCS update is set. Otherwise, it will produce confusing errors.
Details
- Reviewers
jhb
$ WITHOUT_RCS=1 make buildworld
$ WITHOUT_RCS=1 make installworld
$ WITHOUT_RCS=1 make delete-old
<Check that there is no /usr/sbin/etcupdate>
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
tools/build/mk/OptionalObsoleteFiles.inc | ||
---|---|---|
3800 | There's an etcupdate manpage as well. |
Huh, the latest update dropped the changes to stop installing it and now only shows the OptionalObsoleteFiles.inc change. Is that just arc getting confused?
Yes, that's just arc confusion. Maybe it's because when I did the "arc diff --update D691 [path]" command, I didn't include the unchanged files in the path. I only included the files that had changed since I created the review. I'll try updating the review a third time.
Attempt to get arc to show all changed files. This diff does not represent any actual code changes; just review content changes.
Yes, it is apparently a "feature" of arc that it only uploads the files you list, and if you don't explicitly list them, it uploads every diff in your checkout. I find this particular misfeature a bit annoying compared to other systems that let you edit the list of files to upload interactively.