Page MenuHomeFreeBSD
Differential D6881

ul(1) truncates long lines
ClosedPublic
Actions

Authored by gahr on Jun 17 2016, 2:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 7:32 AM
Unknown Object (File)
Thu, Dec 5, 6:52 AM
Unknown Object (File)
Wed, Dec 4, 9:04 AM
Unknown Object (File)
Dec 3 2024, 9:45 AM
Unknown Object (File)
Nov 29 2024, 9:40 AM
Unknown Object (File)
Nov 25 2024, 9:42 PM
Unknown Object (File)
Nov 25 2024, 12:49 PM
Unknown Object (File)
Nov 23 2024, 11:36 PM
View All Files
Subscribers
imp

Details

Reviewers
cognet
bapt
Commits
rS307619: MFC r302558:
rS303075: MFC r302558:
rS302558: Do not truncate lines longer than 512 chars.
Summary

ul(1) holds a static buffer of 512 characters and truncates any line longer than that.

The attached patch allows expanding the buffer to accommodate lines longer than 512 characters. This is only done on the first occurrence of such a line, so for most files no dynamic allocation is needed.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210344

Test Plan

Unpatched version

 # perl -e 'print "A" x 512; print "BBB\n"' | /usr/bin/ul
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAA

Patched version

# perl -e 'print "A" x 512; print "BBB\n"' | ./ul                                                                           
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAABBB

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

gahr updated this revision to Diff 17660.Jun 17 2016, 2:40 PM
gahr retitled this revision from to ul(1) truncates long lines.
gahr updated this object.
gahr edited the test plan for this revision. (Show Details)
gahr added a reviewer: cognet.
gahr set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJun 17 2016, 2:40 PM
gahr updated this object.Jun 17 2016, 2:40 PM
gahr updated this revision to Diff 17661.Jun 17 2016, 2:47 PM
gahr updated this revision to Diff 17662.Jun 17 2016, 2:52 PM
gahr removed rS FreeBSD src repository - subversion as the repository for this revision.

Fixed C99-style comments.

bapt accepted this revision.Jun 17 2016, 3:35 PM
bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Jun 17 2016, 3:35 PM
gahr updated this revision to Diff 17663.Jun 17 2016, 3:38 PM
gahr edited edge metadata.
gahr set the repository for this revision to rS FreeBSD src repository - subversion.

No initialization in definition of int copy.

This revision now requires review to proceed.Jun 17 2016, 3:38 PM
bapt accepted this revision.Jul 1 2016, 7:12 AM
bapt edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 7:12 AM
Closed by commit rS302558: Do not truncate lines longer than 512 chars. (authored by gahr). · Explain WhyJul 11 2016, 8:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
ul/
229 lines

Diff 17663

View Options

usr.bin/ul/ul.c

Loading...