Add RTL8366SR support at etherswitch driver
it looks good! Let's just move chipid into the driver softc and then we're ready to commit it to -HEAD!
|387 ↗||(On Diff #17490)|
Ideally chipid would be a flag in the softc, rather than a global. I know, it's highly unlikely that someone'll put more than one of these on a board. It's just the "better" way to do it.
|95 ↗||(On Diff #17492)|
As guy who worked with number of switch chips, I have to ask:
the current diff isn't against head, it looks like it's against a previous diff :) can you upload a fresh diff against head?
that way I can see what needs to be tidied up before it's commited.
The latest diff is /still/ not against an un-modified freebsd-head tree. :-)
Sorry! Would you please diff your directory against the latest freebsd-head rather than your local repo and send up a diff?
|475–476 ↗||(On Diff #18833)|
Please use /* */ comments
|164–173 ↗||(On Diff #18833)|
As @ray mentioned, could you please move condition to SC/HAL layer.