Page MenuHomeFreeBSD
Differential D6779

Removing dead code.
ClosedPublic
Actions

Authored by mat on Jun 8 2016, 11:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 31, 11:47 PM
Unknown Object (File)
Fri, Oct 31, 5:08 AM
Unknown Object (File)
Wed, Oct 29, 1:10 PM
Unknown Object (File)
Sat, Oct 25, 12:28 AM
Unknown Object (File)
Fri, Oct 24, 8:42 PM
Unknown Object (File)
Fri, Oct 24, 7:06 AM
Unknown Object (File)
Thu, Oct 23, 10:00 AM
Unknown Object (File)
Tue, Oct 21, 5:57 AM
View All Files
Subscribers
bapt

Details

Reviewers
bapt
Group Reviewers
portmgr
Commits
rP417113: Add a few checks for (MASTER|PATCH)_SITES groups.
rP417112: Extract create-manifest.
rP417111: Reverse tests to decrease complexity.
rP417110: Remove unnecessary evals that do-fetch was using.
rP417109: Simplify do-fetch, and remove now unused code.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4155
Build 4198: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 17442.Jun 8 2016, 11:01 PM
mat retitled this revision from to Removing dead code..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
Herald added a reviewer: portmgr. · View Herald TranscriptJun 8 2016, 11:01 PM
mat updated this revision to Diff 17450.Jun 9 2016, 2:43 AM
mat edited edge metadata.
  • Remove the double eval that do-fetch was using.
Herald edited edge metadata. · View Herald TranscriptJun 9 2016, 2:43 AM
mat updated this revision to Diff 17478.Jun 9 2016, 9:01 PM
mat edited edge metadata.
  • Only check the size if the file has a size.
  • The file is now supposed to be unescaped, and expand a comment.
  • Fix some stuff.
  • Reverse tests to decrease complexity.
Herald edited edge metadata. · View Herald TranscriptJun 9 2016, 9:01 PM
mat updated this revision to Diff 17486.Jun 10 2016, 1:35 AM
mat edited edge metadata.
  • Extract create-manifest.
Herald edited edge metadata. · View Herald TranscriptJun 10 2016, 1:35 AM
bapt accepted this revision.Jun 10 2016, 7:30 PM
bapt added a reviewer: bapt.
bapt added a subscriber: bapt.

nice one!

This revision is now accepted and ready to land.Jun 10 2016, 7:30 PM
mat updated this revision to Diff 17503.Jun 11 2016, 1:31 AM
mat edited edge metadata.
  • Don't need MANIFESTF in b.p.m any more. If +DISPLAY is empty, remove it.
This revision now requires review to proceed.Jun 11 2016, 1:31 AM
mat updated this revision to Diff 17586.Jun 14 2016, 6:24 PM
mat edited edge metadata.
  • Fix FETCH_ENV. (For the all of one port using it.)
  • Fix fetch for geomWatch & xpi-splash.
  • Remove the eval/quote madness that was just fixed.
  • More eval madness.
  • Fix.
mat updated this revision to Diff 17587.Jun 14 2016, 6:29 PM
  • validate environment of create-manifest.
mat updated this revision to Diff 17588.Jun 14 2016, 7:01 PM
  • Add a few checks for (MASTER|PATCH)_SITES groups that have dashes (or
mat updated this revision to Diff 17597.Jun 15 2016, 1:53 PM

rebase.

Closed by commit rP417109: Simplify do-fetch, and remove now unused code. (authored by mat). · Explain WhyJun 19 2016, 11:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
91 lines
73 lines
sysutils/
geomWatch/
2 lines
www/
xpi-splash/
2 lines

Diff 17450

View Options

Mk/Scripts/do-fetch.sh

Loading...
View Options

Mk/bsd.port.mk

Loading...
View Options

sysutils/geomWatch/Makefile

Loading...
View Options

www/xpi-splash/Makefile

Loading...