Page MenuHomeFreeBSD

Make pure-ftpd flags configurable in /etc/rc.conf
ClosedPublic

Authored by asomers on Jun 1 2016, 4:49 PM.

Details

Summary

Recognize a "pureftpd_flags" variable in pure-ftpd's rc script. Pretty much
anything that can be placed in /usr/local/etc/pure-ftpd.conf can be placed in
this variable instead.

ftp/pure-ftpd/Makefile
Bump PORTREVISION

ftp/pure-ftpd/files/pure-ftpd.in
Handle pureftpd_flags. It needs special handling because, unlike most
daemons, pure-config.pl takes its mandatory argument first and its
optional flags last.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers retitled this revision from to Make pure-ftpd flags configurable in /etc/rc.conf.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: sunpoet.
asomers added a subscriber: brd.
ftp/pure-ftpd/files/pure-ftpd.in
52 ↗(On Diff #17188)

What is the point of flags here? Maybe that should be pureftpd_flags?

ftp/pure-ftpd/files/pure-ftpd.in
52 ↗(On Diff #17188)

"flags" is understood by /etc/rc.subr in run_rc_command. Long story short, run_rc_command will run

$command $rc_flags $command_args

which expands to

pure-config.pl $flags $pureftpd_flags

which expands to

pure-config.pl ${pureftpd_config} -g{$pidfile} <whatever>

I plan to commit this tomorrow if I don't hear from anyone.

This revision was automatically updated to reflect the committed changes.