rc.conf
ClosedPublic
Actions

Authored by asomers on Jun 1 2016, 4:49 PM.

Details

Reviewers

Commits

rP418610: Make pure-ftpd flags configurable in /etc/rc.conf

Summary

Recognize a "pureftpd_flags" variable in pure-ftpd's rc script. Pretty much
anything that can be placed in /usr/local/etc/pure-ftpd.conf can be placed in
this variable instead.

ftp/pure-ftpd/Makefile
Bump PORTREVISION

ftp/pure-ftpd/files/pure-ftpd.in
Handle pureftpd_flags. It needs special handling because, unlike most
daemons, pure-config.pl takes its mandatory argument first and its
optional flags last.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers updated this revision to Diff 17188.Jun 1 2016, 4:49 PM

asomers retitled this revision from to Make pure-ftpd flags configurable in /etc/rc.conf.

asomers updated this object.

asomers edited the test plan for this revision. (Show Details)

asomers added a reviewer: sunpoet.

asomers added a subscriber: brd.

Herald added a subscriber: mat. · View Herald TranscriptJun 1 2016, 4:49 PM

brd added inline comments.Jun 1 2016, 8:05 PM

ftp/pure-ftpd/files/pure-ftpd.in
52 ↗	(On Diff #17188)	What is the point of flags here? Maybe that should be pureftpd_flags?

asomers added inline comments.Jun 1 2016, 8:09 PM

ftp/pure-ftpd/files/pure-ftpd.in
52 ↗	(On Diff #17188)	"flags" is understood by /etc/rc.subr in run_rc_command. Long story short, run_rc_command will run $command $rc_flags $command_args which expands to pure-config.pl $flags $pureftpd_flags which expands to pure-config.pl ${pureftpd_config} -g{$pidfile} <whatever>