Page MenuHomeFreeBSD
Differential D6653

if_dwc: Multicast and FCS fixes
ClosedPublic
Actions

Authored by jmcneill on May 31 2016, 12:27 AM.
Tags
Referenced Files
F131805477: D6653.diff
Sat, Oct 11, 7:45 AM
Unknown Object (File)
Sun, Sep 21, 3:02 AM
Unknown Object (File)
Sep 4 2025, 4:16 AM
Unknown Object (File)
Aug 29 2025, 4:35 AM
Unknown Object (File)
Aug 24 2025, 12:24 AM
Unknown Object (File)
Aug 15 2025, 10:25 AM
Unknown Object (File)
Jul 26 2025, 11:50 PM
Unknown Object (File)
Jul 9 2025, 11:02 PM
View All Files
Subscribers
imp

Details

Reviewers
loos
Group Reviewers
ARM
Commits
rS301693: Multicast filters on DWC_GMAC_ALT_DESC type implementations use a different
Summary

Multicast filters are different between the two versions of dwc supported by the driver. This patch adds support for the second (DWC_GMAC_ALT_DESC mode) type of filters.

In addition, remove trailing FCS in receive path. dhclient complains:

ip length 334 disagrees with bytes received 338.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jmcneill updated this revision to Diff 17125.May 31 2016, 12:27 AM
jmcneill retitled this revision from to if_dwc: Fix multicast in DWC_GMAC_ALT_DESC mode.
jmcneill updated this object.
jmcneill edited the test plan for this revision. (Show Details)
jmcneill added reviewers: ARM, loos.
jmcneill set the repository for this revision to rS FreeBSD src repository - subversion.
jmcneill added a project: ARM.
Herald added a subscriber: imp. · View Herald TranscriptMay 31 2016, 12:27 AM
jmcneill updated this revision to Diff 17142.May 31 2016, 9:26 AM
jmcneill updated this revision to Diff 17143.May 31 2016, 9:51 AM
jmcneill retitled this revision from if_dwc: Fix multicast in DWC_GMAC_ALT_DESC mode to if_dwc: Multicast and FCS fixes.
jmcneill updated this object.

Remove trailing FCS in receive path. Fixes "ip length XXX disagrees with bytes received YYY" message from dhclient.

jmcneill added inline comments.May 31 2016, 9:55 AM
sys/dev/dwc/if_dwc.c
772 ↗(On Diff #17143)

I wanted to use M_HASFCS here but if_ethersubr.c passes the mbuf to BPF before stripping FCS (so dhclient still complained).

loos accepted this revision.Jun 4 2016, 3:09 PM
loos edited edge metadata.
This revision is now accepted and ready to land.Jun 4 2016, 3:09 PM
Closed by commit rS301693: Multicast filters on DWC_GMAC_ALT_DESC type implementations use a different (authored by jmcneill). · Explain WhyJun 8 2016, 8:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
dwc/
30 lines

Diff 17436

View Options

head/sys/dev/dwc/if_dwc.c

Loading...