Page MenuHomeFreeBSD

[versions] igor -Ry and some other rewording and fixes.

Authored by mat on Aug 20 2014, 3:09 PM.


Diff Detail

rD FreeBSD doc repository - subversion
Lint Skipped
Unit Tests Skipped

Event Timeline

mat retitled this revision from to [versions] igor -Ry and some other rewording and fixes..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
wblock added inline comments.
1098 ↗(On Diff #1227)

Using "should" as a recommendation is okay. But here it could be imperative:

<entry>&lt;sys/dkstat.h&gt; is empty. Do not include it.</entry>

2503 ↗(On Diff #1227)

"Use struct ipmregn instead."

3519 ↗(On Diff #1227)

This depends on what the code actually does. There are small differences:

"should" is a recommendation.
"can" means it is optional.

"can" is probably okay, but implies that the counting might not be skipped.

4718 ↗(On Diff #1227)


With wblock's comments

mat updated this revision to Diff 1326.

Closed by commit rD45540 (authored by @mat).