[BHND] Add logging macroses

[mizhka]

Summary

There are 5 logging levels:

• ERROR
• WARN
• INFO
• DEBUG
• TRACE

There are 2 logging context:

• with
• without device

DEBUG and TRACE records are printed only if bootverbose
Logging records are printed with source code line information if acceptable logging level is DEBUG or TRACE

[landon_landonf.org]

Can you do a style(9) rework of this one?

Relevant style(9) guidelines:

• Put a single tab character between the #define and the macro name.
• The comment for #endif should match the expression used in the corresponding #if or #ifdef (e.g. #endif /* BHND_LOGGING >= BHND_WARN_LEVEL */)
• Try to wrap these longer defines to keep lines <= 80 chars
• Multi-statement macros should be encapsulated in a do { } while(0) loop

Lastly, a non-style(9) request:

Can you rework these to use C string literal concatenation and varargs to allow format strings? e.g., something like:

#define	BHND_LOG_PRINT(level, fmt...)	\
    printf("[BHND " level "] => %s:%d: " fmt,, __func__, __LINE__, ## __VA_ARGS__)

[landon_landonf.org]

sys/dev/bhnd/bhnd_debug.h

30 ↗

(On Diff #15983)

I'm not sure style(9) actually defines this, but #if-style header guards should be used here (e.g. #ifndef _BHND_DEBUG_H_)

[imp]

sys/dev/bhnd/bhnd_debug.h

30 ↗

(On Diff #15983)

#pragma once isn't standardized.

And the tree is split between _FILE_ and _DIR_FILE_ for the guard name.

[mizhka]

• removed #pragma once
• added VA_ARGS usage
• level is C concatened instead printf formatting

[landon_landonf.org]

sys/dev/bhnd/bhnd_debug.h

47 ↗

(On Diff #16041)

These still need do {} while(0) loops around multiple statements, and line-breaks at 80 chars.

You can avoid the trailing printf("\n") (and the need for do {} while(0) on some of the defines) if you go with something like:

printf("bhnd: " fmt "\n", ## __VA_ARGS__);

[mizhka]

• refactoring
• fixed style(9) issues
• described how to use macroses

[landon_landonf.org]

If @adrian is OK with the BHND_LOGLEVEL addition to sys/conf, the rest looks good to me.