Differential D6242

[BCM] Improve MIPS trampoline code
ClosedPublic
Actions

Authored by mizhka on May 6 2016, 5:12 PM.

Details

Reviewers

adrian

Group Reviewers

MIPS

Commits

rS299993: [mips] Improve MIPS trampoline code

Summary

This patch fix trampoline build. inckern.S increases stack and calls _startC of elf_trampoline, so inckern.S should be called before elf_trampoline. gcc4.2 puts text (code) into image according to order of source files in this call, so order has changed.
In addition make will install trampoline kernel. It allows to use kernel for firmware build.

Test Plan

Tested on MIPS ASUS boards

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mizhka updated this revision to Diff 15976.May 6 2016, 5:12 PM

mizhka retitled this revision from to [BCM] Improve MIPS trampoline code.

mizhka updated this object.

mizhka edited the test plan for this revision. (Show Details)

mizhka added a reviewer: adrian.

mizhka set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMay 6 2016, 5:12 PM

This requires more eyeballs!

imp added inline comments.May 6 2016, 9:34 PM

sys/conf/Makefile.mips
40 ↗	(On Diff #15976)	This no longer looks like an obscure value. Why the change? If nothing else the comment sounds wrong relative to the commit message.
76 ↗	(On Diff #15976)	Why reorder here?

landon_landonf.org added a subscriber: landon_landonf.org.May 6 2016, 10:57 PM

mizhka added inline comments.May 8 2016, 9:35 PM

sys/conf/Makefile.mips
40 ↗	(On Diff #15976)	Yes, comment to be corrected. Moreover, it's better to make trampoline load address as parameter of kernel configuration. Is it possible? Sorry, but I don't know how to do it.
76 ↗	(On Diff #15976)	inckern.S increase stack and calls _startC of elf_trampoline, so inckern.S should be called before elf_trampoline. gcc4.2 puts text (code) into image according to order of source files in this call, so order has changed.