vidcontrol: improve error handling
AbandonedPublic
Actions

Authored by emaste on May 2 2016, 6:04 PM.

Details

Reviewers

cturt_hardenedbsd.org
ngie

Summary

We can just exit in the case of errors.

PR: 209078
Reported by: cturt@hardenedbsd.org

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 15823.May 2 2016, 6:04 PM

emaste retitled this revision from to vidcontrol: improve error handling.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: cturt_hardenedbsd.org.

also free mappings in success case

This is going to increase the number of "false positives" with Coverity (err* with fopened FILE*), but the change LGTM.

This revision is now accepted and ready to land.May 2 2016, 6:48 PM

ngie added inline comments.May 2 2016, 6:49 PM

usr.sbin/vidcontrol/vidcontrol.c
458–459	Thank you for fixing this BTW :)..

This is going to increase the number of "false positives" with Coverity (err* with fopened FILE*)

I'm not sure exactly what you mean here, can you clarify?

In D6178#131571, @emaste wrote:

This is going to increase the number of "false positives" with Coverity (err* with fopened FILE*)

I'm not sure exactly what you mean here, can you clarify?

I'll have to go back and look. IIRC, err* wasn't instrumented properly with Coverity and file descriptors and items after the call were marked as false positives.

emaste mentioned this in D8176: vidcontrol: improve error handling in vt(4) font loading.Oct 12 2016, 1:22 PM

Change in D8176 committed instead.

Revision Contents
Changeset List

Path

Size

usr.sbin/

vidcontrol/

vidcontrol.c

46 lines

Diff 15825

View Options

usr.sbin/vidcontrol/vidcontrol.c

vidcontrol: improve error handlingAbandonedPublicActions