Page MenuHomeFreeBSD
Differential D6178

vidcontrol: improve error handling
AbandonedPublic
Actions

Authored by emaste on May 2 2016, 6:04 PM.
Tags
None
Referenced Files
F150697325: D6178.id15823.diff
Fri, Apr 3, 10:52 AM
Unknown Object (File)
Fri, Apr 3, 10:47 AM
Unknown Object (File)
Sun, Mar 29, 7:55 PM
Unknown Object (File)
Wed, Mar 25, 6:18 PM
Unknown Object (File)
Wed, Mar 25, 6:17 PM
Unknown Object (File)
Tue, Mar 24, 5:34 PM
Unknown Object (File)
Tue, Mar 24, 5:34 PM
Unknown Object (File)
Tue, Mar 17, 5:09 AM
View All Files
Subscribers
ngie

Details

Reviewers
cturt_hardenedbsd.org
ngie
Summary

We can just exit in the case of errors.

PR: 209078
Reported by: cturt@hardenedbsd.org

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 15823.May 2 2016, 6:04 PM
emaste retitled this revision from to vidcontrol: improve error handling.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: cturt_hardenedbsd.org.
emaste updated this revision to Diff 15825.May 2 2016, 6:10 PM

also free mappings in success case

ngie accepted this revision.May 2 2016, 6:48 PM
ngie added a reviewer: ngie.
ngie added a subscriber: ngie.

This is going to increase the number of "false positives" with Coverity (err* with fopened FILE*), but the change LGTM.

This revision is now accepted and ready to land.May 2 2016, 6:48 PM
ngie added inline comments.May 2 2016, 6:49 PM
usr.sbin/vidcontrol/vidcontrol.c
458–459

Thank you for fixing this BTW :)..

emaste added a comment.May 2 2016, 6:56 PM

This is going to increase the number of "false positives" with Coverity (err* with fopened FILE*)

I'm not sure exactly what you mean here, can you clarify?

ngie added a comment.May 5 2016, 6:44 PM
In D6178#131571, @emaste wrote:

This is going to increase the number of "false positives" with Coverity (err* with fopened FILE*)

I'm not sure exactly what you mean here, can you clarify?

I'll have to go back and look. IIRC, err* wasn't instrumented properly with Coverity and file descriptors and items after the call were marked as false positives.

emaste mentioned this in D8176: vidcontrol: improve error handling in vt(4) font loading.Oct 12 2016, 1:22 PM
emaste abandoned this revision.Nov 4 2016, 8:33 PM

Change in D8176 committed instead.

Revision Contents
Changeset List

PathSize
usr.sbin/
vidcontrol/
46 lines

Diff 15825

View Options

usr.sbin/vidcontrol/vidcontrol.c

Loading...