Bug 206940 - zpool (command terminology) misused to describe a pool
ClosedPublic
Actions

Authored by sd_beastie.io on Apr 30 2016, 2:46 PM.

Details

Reviewers

allanjude
wblock

Commits

rD48889: Correct misusage of "zpool".

Summary

Change incorrect term zpool to pool. It should be 'pool' to be correct even though informally, everyone refers to the pool as zpool.

Test Plan

igor and full doc build

Repository

rD FreeBSD doc repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

sd_beastie.io retitled this revision from to Bug 206940 - zpool (command terminology) misused to describe a pool.

sd_beastie.io updated this object.

sd_beastie.io edited the test plan for this revision. (Show Details)

en_US.ISO8859-1/books/handbook/zfs/chapter.xml
2440 ↗	(On Diff #15771)	This is output from a command and should not be changed. Or rather, changed in the source, but not here.
3479 ↗	(On Diff #15771)	The ID change is okay, but it is important to build the document to make sure that xrefs to the previous name aren't broken.
3537 ↗	(On Diff #15771)	Better to use <command> here rather than the man reference: in <command>zpool create</command>. All vdevs
3538 ↗	(On Diff #15771)	Moving the "must be" to this line is a whitespace-only change, and should not be mixed with a content change. But the suggestion for the previous line makes that unnecessary anyway.

Done - patch coming soon.

en_US.ISO8859-1/books/handbook/zfs/chapter.xml
3479 ↗	(On Diff #15771)	xref checked by full build.
3538 ↗	(On Diff #15771)	This still ends up being on the next line b/c of the command start and end tags.

Updated diff based on review comments

en_US.ISO8859-1/books/handbook/zfs/chapter.xml
2268 ↗	(On Diff #16746)	Not your fault, but the "no files can be" is just unpleasant. Better: Files cannot be
3538 ↗	(On Diff #15771)	No, wrapping that line is a whitespace-only change. So you have to break the formatting rules while making the content change: in <command>zpool create</command>. All vdevs must be at least 128 MB in size.</para> That too-long line will be fixed in the followup whitespace-only commit.