Differential D60932

snmp_wlan: several fixes in mac policy handling
Needs ReviewPublic
Actions

Authored by maxim on Tue, Oct 20, 10:49 PM.

Project Tags

None

Referenced Files

None

Subscribers

imp

Details

Reviewers

syrinx
bz

Summary

two places where the data returned by ioctl() was not used
fix wif->mac_nacls math
plug memory leaks in wlan_get_mac_acl_macs()

Fixes: 09cbe818f0a2 ("Bring in a SNMP module to support monitoring cloned wireless interfaces ...")
MFC after: 1 month
Found by: clang static analyzer (alpha.deadcode.UnreachableCode) and Claude Code Opus 5.5

Test Plan

Unfortunately, I don't really have a real hardware to test it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78452
Build 75335: arc lint + arc unit

Event Timeline

maxim created this revision.Tue, Oct 20, 10:49 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 20, 10:49 PM

maxim requested review of this revision.Tue, Oct 20, 10:49 PM

Harbormaster completed remote builds in B78452: Diff 190470.Tue, Oct 20, 10:49 PM

maxim edited the summary of this revision. (Show Details)Tue, Oct 20, 10:51 PM

maxim edited the test plan for this revision. (Show Details)

maxim added reviewers: syrinx, bz.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsnmpd/

modules/

snmp_wlan/

wlan_sys.c

10 lines

Diff 190470

View Options

usr.sbin/bsnmpd/modules/snmp_wlan/wlan_sys.c

snmp_wlan: several fixes in mac policy handlingNeeds ReviewPublicActions