sysutils/f3: Fix build on i386

[longros]

Summary

The MIN macro in libutils.h had no support for ints, as a result commit bf3dd41 caused f3 to fail to compile on 32-bit architectures. Fixed upstream in 0d08c4e.

Test Plan

poudriere testport passes in 14.4-RELEASE i386 with the patch and also on 15.1-RELEASE amd64

[yuri]

Hi Christos,

Several problems:

1. When you add a patch you should always add a comment in the first lines of the patch explaining why is it needed. This is especially important for a patch like this one when it isn't obvious why does it solve a problem stated in the subject.
2. Bump in the Makefile is needed because this is a code change that might affect binaries on all architectures, at least from the first look.
3. Such change should be upstreamed if possible. Please mention in the patch comment whether you upstreamed it. In case of a GitHub hosted project like this one a pull request URL would be appropriate. I use the GitHub's gh CLI to create such PRs completely from the command line. gh makes it very easy.

[longros]

In D60719#1392557, @yuri wrote:

Hi Christos,

Several problems:

1. When you add a patch you should always add a comment in the first lines of the patch explaining why is it needed. This is especially important for a patch like this one when it isn't obvious why does it solve a problem stated in the subject.
2. Bump in the Makefile is needed because this is a code change that might affect binaries on all architectures, at least from the first look.
3. Such change should be upstreamed if possible. Please mention in the patch comment whether you upstreamed it. In case of a GitHub hosted project like this one a pull request URL would be appropriate. I use the GitHub's gh CLI to create such PRs completely from the command line. gh makes it very easy.

Thanks for the feedback Yuri. The change is upstream in the main but there is no new release with it yet.

[yuri]

In D60719#1392563, @longros wrote:

Thanks for the feedback Yuri. The change is upstream in the main but there is no new release with it yet.

Then you should say in the comment that this is a back-ported change/fix from the upstream.