The workaround of building the port while staging
now seems unnecessary.
Details
- Reviewers
pkubaj arrowd kenrap_kennethraplee.com
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 79396 Build 76279: arc lint + arc unit
Event Timeline
The workaround of building the port while staging now seems unnecessary.
Hmm, can you expand why?
From https://reviews.freebsd.org/D51165,
Zig does not have separate build and install stages. At least, I haven't figured a way to separate them, so I made do-build a noop and do-install to perform both building and installing. This allows make restage to work
This patch is a way to separate the lack of build and install stages. It will first build into the wrkdir's zig cache, then install from the already built cache into PREFIX with DESTDIR as the install root. make restage works just fine with this, it doesn't rebuild.
I don't think so in this case, this patch is for the freebsd ports specific things.
I will apply your feedback soon in the next revision.
I guess, this will have to wait until all Zig versions support this feature?
Isn't astro/mepo the only remaining consumer of zig014? PR 299269 already aims to either fork it or drop it. zig015 works with this patch.
Sorry for the slow reply. Yeah, both that and after a mini exp-run on all Zig ports.
I'll work on the mini exp-runs and share feedback here if needed.
I've done my mini zig exp-run on my part and everything looks good to me.
arrowd will likely follow-up on more reviews if needed.
So sorry! I completely forgot to address the feedback in the last
revision. Fixed now, let me know if this is better.