New port: net/mlvpn (Multilink VPN for bonding multiple ISP links)

[olivier]

Summary

This port add a new UID and GID.
poudriere test log here:

• head-amd64: http://dev.bsdrp.net/poudriere/11amd64-default/mlvpn-2.3.1.log - 10.2-i386: http://dev.bsdrp.net/poudriere/102i386-default/mlvpn-2.3.1.log

Feature and RC script tested here: http://bsdrp.net/documentation/examples/aggregating_multiple_isp_links_with_mlvpn

[olivier]

Fix tab space

[mat]

Please, regenerate the patches with make makepatch.

Also, did you run the rc file through devel/rclint ?

net/mlvpn/Makefile

14–15

Remove ${PORTSDIR}/

20

You should put PORTNAME=MLVPN, or GH_PROJECT=MLVPN. It only works by chance because github projects are case insensitives.

37–39

This maps to:

CONTROL_CONFIGURE_OFF=--disable-control

But I guess it should be more along the lines of:

CONTROL_CONFIGURE_ENABLE=control

48–49

The modes should go in the plist.

[olivier]

Updating port following mat's comments. But I didn't reach to use rclint: it generates a "IndexError: string index out of range"

[mat]

net/mlvpn/Makefile

21

Then you can remove this line.

24–25

Instead of this, you should USES=localbase

43

I think this, too, should be a .sample, unless it's a script the user will never change.

net/mlvpn/pkg-plist

5–6

You forgot to add the modes here, unless they are not needed.

[jadawin]

As mat is absolutely everywhere and doesn't trust other mentors/committers, i let mat approve this one.
I already asked mat to let us (tabthorpe and myself) do our mentors jobs but he doesn't care. I have no problem with double checks but you don't let me time to have a first look. This is a lack of respect for mentors and a lack of respect since i already asked you to stop.

[olivier]

Continue improving. I didn't put the srcipt in sample because user should not modifying it.

[olivier]

Forgot to update net/Makefile

[olivier]

Mat, are you okay with the current status of this port ?

[mat]

net/mlvpn/Makefile

21

This line can be removed.

net/mlvpn/distinfo

2–3

I think you forgot to run make makesum, this doesn't seem to be correct.

net/mlvpn/pkg-plist

5–6

I don't know how the software works, but these will only be readable by root, and it seems to be running as user mlvpn.

[olivier]

net/mlvpn/distinfo

2–3

This distinfo is the good one, my retry give me the same output:

root@lame4:/usr/ports/net/mlvpn # make distclean
===>  Cleaning for mlvpn-2.3.1
===>  Deleting distfiles for mlvpn-2.3.1
root@lame4:/usr/ports/net/mlvpn # make makesum
===>  License BSD2CLAUSE accepted by the user
===>  Found saved configuration for mlvpn-2.3.1
===>   mlvpn-2.3.1 depends on file: /usr/local/sbin/pkg - found
=> zehome-MLVPN-2.3.1_GH0.tar.gz doesn't seem to exist in /usr/local/poudriere/ports/default/distfiles/.
=> Attempting to fetch https://codeload.github.com/zehome/MLVPN/tar.gz/2.3.1?dummy=/zehome-MLVPN-2.3.1_GH0.tar.gz
zehome-MLVPN-2.3.1_GH0.tar.gz                 100% of   81 kB  375 kBps 00m00s
===> Fetching all distfiles required by mlvpn-2.3.1 for building
root@lame4:/usr/ports/net/mlvpn # cat distinfo
SHA256 (zehome-MLVPN-2.3.1_GH0.tar.gz) = 4bbe8ae10ccad4ba764d29db0293b3ab523ded5d0a0b5adbe6a8d4d839e4138e
SIZE (zehome-MLVPN-2.3.1_GH0.tar.gz) = 83817

net/mlvpn/pkg-plist

5–6

mlvpn start as root and open configuration with its root right then switch to mlvpn user.

[olivier]

Remove a useless line in Makefile

[mat]

Look with your eyes, you just said:

root@lame4:/usr/ports/net/mlvpn # cat distinfo
SHA256 (zehome-MLVPN-2.3.1_GH0.tar.gz) = 4bbe8ae10ccad4ba764d29db0293b3ab523ded5d0a0b5adbe6a8d4d839e4138e
SIZE (zehome-MLVPN-2.3.1_GH0.tar.gz) = 83817

Look at the content of the distinfo in the review, it containt this:

SHA256 (zehome-mlvpn-2.3.1_GH0.tar.gz) = 4bbe8ae10ccad4ba764d29db0293b3ab523ded5d0a0b5adbe6a8d4d839e4138e
SIZE (zehome-mlvpn-2.3.1_GH0.tar.gz) = 83817

It is not the same.

It may be ok on your local directory, but it is not here.

[olivier]

Update filename in distinfo