net80211: replace internal LE_READ_*/LE_WRITE_* macro with system le*dec / le*enc

[avos]

Summary

Replace net80211 specific macros with system-wide bytestream encoding/decoding functions:

• LE_READ_2 -> le16dec
• LE_READ_4 -> le32dec
• LE_WRITE_2 -> le16enc
• LE_WRITE_4 -> le32enc

+ drop ieee80211_input.h include, where it was included for these operations only.

[adrian]

I'll check with dragonflybsd about the endian conversion routines to make sure they have the same ones in the same place.

I'd like to see a first pass be "remove all other definitions of LE_*" but I fear that'll introduce more ieee80211_input.h including.

[avos]

In D6030#128349, @adrian wrote:

I'll check with dragonflybsd about the endian conversion routines to make sure they have the same ones in the same place.

http://gitweb.dragonflybsd.org/dragonfly.git/blob/HEAD:/sys/sys/endian.h
le{16,32}{dec,enc} were added in 2004

I'd like to see a first pass be "remove all other definitions of LE_*" but I fear that'll introduce more ieee80211_input.h including.

Yes + LE_WRITE_* need to be moved to some appropriate header in this case.

P.S. there is another one definition of LE_READ_{2,4} in <dev/ath/ath_hal/ah_internal.h> (untouched because it is used by <contrib/dev/ath/ath_hal/ar9300>).

[adrian]

ok, let's do it then. We can always modify it later if someone comes along and complains about portability.