Differential D59991

jh7110_gpio: handle preset high/low
ClosedPublic
Actions

Authored by mhorne on Thu, Sep 24, 4:35 PM.

Details

Reviewers

bscott_bunyatech.com.au

Group Reviewers

riscv

Commits

rGa0c0f12c1bbc: jh7110_gpio: handle preset high/low
rG6f9d0f02e72c: jh7110_gpio: handle preset high/low

Summary

Take action in the presence of the GPIO_PIN_PRESET_LOW/HIGH flags. This
part of the GPIO interface seems to be unused, but is trivially
implemented in our driver.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Thu, Sep 24, 4:35 PM

Herald added subscribers: loos, imp. · View Herald TranscriptThu, Sep 24, 4:35 PM

mhorne requested review of this revision.Thu, Sep 24, 4:35 PM

Harbormaster completed remote builds in B77284: Diff 187617.Thu, Sep 24, 4:35 PM

mhorne added a child revision: D59992: jh7110_gpio: fdt_pinctrl interface.Thu, Sep 24, 4:35 PM

Works fine for me.
Can't say if it works 100% correctly since there is a (very short) delay between setting the pin to output and setting the value. I don't have equipment to see how long that delay is in practice but suspect it is way to fast to be noticed for any practical use. I wonder if it is possible to set the value before setting the pin to output? I haven't seen anything suggesting that it is either possible or impossible.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 30, 7:28 PM

Closed by commit rG6f9d0f02e72c: jh7110_gpio: handle preset high/low (authored by mhorne). · Explain Why

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG6f9d0f02e72c: jh7110_gpio: handle preset high/low.

mhorne added a commit: rGa0c0f12c1bbc: jh7110_gpio: handle preset high/low.Wed, Oct 7, 4:56 PM