Page MenuHomeFreeBSD

sdhci_fdt_spacemit: Avoid setting the 'io' clock
Needs ReviewPublic

Authored by bnovkov on Tue, Sep 22, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 25, 4:52 AM
Unknown Object (File)
Thu, Sep 24, 11:48 PM
Unknown Object (File)
Thu, Sep 24, 11:48 PM
Unknown Object (File)
Thu, Sep 24, 5:28 PM
Unknown Object (File)
Thu, Sep 24, 12:50 PM
Unknown Object (File)
Thu, Sep 24, 9:30 AM
Unknown Object (File)
Thu, Sep 24, 4:44 AM
Unknown Object (File)
Wed, Sep 23, 7:58 PM
Subscribers

Details

Reviewers
mhorne
Summary

The spacemit SDHCI driver conflated the 'io' clock with the base
SDHCI clock and used in the corresponding 'sdhci_set_clock' interface
method. However, this clock is only meant to limit the maximum speed
of the peripheral. Careful inspection of the corresponding Linux and
(pending) uboot drivers confirms this; the "io" clock is either ignored
or only set during attach and is not touched afterwards.

Fixes: 550db3d6f502

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77198
Build 74081: arc lint + arc unit

Event Timeline

sys/dev/sdhci/sdhci_fdt_spacemit.c
81

What is this clock then? Should it be the one manipulated by the SDHCI_SET_CLOCK() method?