Differential D59801

qlxgbe: Derive the mailbox RSS key from the common key
ClosedPublic
Actions

Authored by kbowling on Fri, Sep 18, 8:45 AM.

Tags

None

Referenced Files

	F172507708: D59801.diff
	Fri, Sep 18, 10:35 PM

	F172465382: D59801.id.diff
	Fri, Sep 18, 4:11 PM

	F172464343: D59801.diff
	Fri, Sep 18, 4:02 PM

	F172435654: D59801.id187044.diff
	Fri, Sep 18, 11:03 AM

	F172435622: D59801.id187060.diff
	Fri, Sep 18, 11:03 AM

	F172434512: D59801.diff
	Fri, Sep 18, 10:55 AM

Subscribers

Details

Reviewers

Commits

rG30fdef26de87: qlxgbe: Derive the mailbox RSS key from the common key

Summary

Replace the embedded key with rss_getkey(), retaining the firmware's
reversed 64-bit word-pair order and low-word-first layout within each
pair.  The common default produces the same mailbox key as the existing
constants, while configured common keys no longer get ignored.

Leave the RSS enable flags, hash types, and indirection policy unchanged.

MFC after:      2 weeks
Sponsored by:   BBOX.io

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling created this revision.Fri, Sep 18, 8:45 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 18, 8:45 AM

kbowling requested review of this revision.Fri, Sep 18, 8:45 AM

kbowling updated this revision to Diff 187060.Fri, Sep 18, 9:22 AM

gallatin accepted this revision.Fri, Sep 18, 8:13 PM

This revision is now accepted and ready to land.Fri, Sep 18, 8:13 PM

Closed by commit rG30fdef26de87: qlxgbe: Derive the mailbox RSS key from the common key (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyFri, Sep 18, 11:06 PM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG30fdef26de87: qlxgbe: Derive the mailbox RSS key from the common key.

Revision Contents
Changeset List

Path

Size

sys/

dev/

qlxgbe/

19 lines

Diff 187175

sys/dev/qlxgbe/ql_hw.c

Loading...