syslogd: reap pipe children on config reload

[bapt]

Summary

On SIGHUP reload, closelogfiles() frees each F_PIPE filed even when its
pipe process is still running. close_filed() sets f_type to F_UNUSED
before the check, so the condition f_type != F_PIPE is always true and
the filed is freed while its process descriptor is still on the dead
queue and registered in the kqueue. When the child later exits, the
NOTE_EXIT handler dereferences the freed filed (use-after-free) and
never closes the process descriptor, leaving the pipe child as a
persistent zombie.

Capture whether the filed is a pipe with an active process descriptor
before calling close_filed(), and defer the free in that case so the
NOTE_EXIT handler can reap the child and free the filed.

Test Plan

with

*.info         |exec /home/bapt/zombies.sh

the script being

#!/bin/sh
while read -r line; do
    :
done

We ensure the script is spawned:
logger -p info -t test "spawn"
pkill -HUP syslogd

here you are you have your zombies

restart syslogd, they are reaped properly.

[markj]

I wrote a regression test case for this bug, will commit it after this patch lands.

Could you please add a Fixes tag to the commit log?