Assign and test `malloc` result separately
ClosedPublic
Actions

Authored by ngie on Aug 30 2026, 6:34 PM.

Details

Reviewers

Commits

rG97ff0d61dbe0: Assign and test `malloc` result separately
rGf3cdf3d5dda3: Assign and test `malloc` result separately
rG2561c468c113: Assign and test `malloc` result separately

Summary

The previous pattern is cited as an issue with ATF 0.22+ when using
clang/gcc post-[1].

MFC after: 2 weeks
Reported by: clang (-Wparenthesis)

[1]: https://github.com/freebsd/atf/pull/72

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Aug 30 2026, 6:34 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 30 2026, 6:34 PM

ngie requested review of this revision.Aug 30 2026, 6:34 PM

Harbormaster completed remote builds in B76334: Diff 185445.Aug 30 2026, 6:34 PM

ngie added a reviewer: des.Aug 30 2026, 6:35 PM

ngie added a subscriber: Src Committers.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 6 2026, 7:19 PM

Closed by commit rG2561c468c113: Assign and test `malloc` result separately (authored by ngie). · Explain Why

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG2561c468c113: Assign and test `malloc` result separately.

ngie added a commit: rGf3cdf3d5dda3: Assign and test `malloc` result separately.Tue, Sep 22, 6:51 AM

ngie added a commit: rG97ff0d61dbe0: Assign and test `malloc` result separately.Tue, Sep 22, 6:54 AM

Revision Contents
Changeset List

Path

Size

lib/

libc/

tests/

stdlib/

qsort_bench.c

2 lines

Diff 186020

View Options

lib/libc/tests/stdlib/qsort_bench.c

Assign and test `malloc` result separatelyClosedPublicActions