uchcom: Set rate to 1
ClosedPublic
Actions

Authored by aokblast on Aug 22 2026, 8:43 PM.

Tags

None

Referenced Files

	F174769427: D59111.diff
	Mon, Oct 5, 9:23 PM

	Unknown Object (File)
	Sun, Oct 4, 10:12 AM

	Unknown Object (File)
	Sun, Oct 4, 12:57 AM

	Unknown Object (File)
	Sat, Oct 3, 11:49 PM

	Unknown Object (File)
	Fri, Oct 2, 8:03 PM

	Unknown Object (File)
	Fri, Oct 2, 9:53 AM

	Unknown Object (File)
	Fri, Oct 2, 12:05 AM

	Unknown Object (File)
	Thu, Oct 1, 11:58 PM

View All 61 Files

Subscribers

imp

Details

Reviewers

imp
emaste

Group Reviewers

USB

Commits

rG228b1a011660: uchcom: Set rate to 1 if 0

Summary

If userspace provides rate == 0, it causes kernel panic as rate is
directly used as a divident, which cannot be zero. Fix it by set the
rate to 1 if it is zero.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aokblast created this revision.Aug 22 2026, 8:43 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 22 2026, 8:43 PM

aokblast requested review of this revision.Aug 22 2026, 8:43 PM

Harbormaster completed remote builds in B75967: Diff 184742.Aug 22 2026, 8:43 PM

aokblast added a reviewer: USB.Aug 22 2026, 8:44 PM

imp accepted this revision.Aug 23 2026, 12:40 AM

This revision is now accepted and ready to land.Aug 23 2026, 12:40 AM

emaste accepted this revision.Aug 23 2026, 6:15 PM

Closed by commit rG228b1a011660: uchcom: Set rate to 1 if 0 (authored by aokblast). · Explain WhySat, Sep 26, 6:45 AM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG228b1a011660: uchcom: Set rate to 1 if 0.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

serial/

uchcom.c

3 lines

Diff 187725

View Options

sys/dev/usb/serial/uchcom.c

uchcom: Set rate to 1ClosedPublicActions