After the baselibs() fix in f0f863b1a2d6, readelf is executed for each
result from find(1). There are two concerns with this fix:
- -exec readelf -d {} \; drops the filename from the error messages
readelf prints "File: <name>" headers only when it is supplied with two
or more files, and baselibs() uses ${file} from those headers. So, the
two err() messages in baselibs() will break.
This is moot for now, though, because nothing in the ports tree can
trigger these errors. Those base soname versions for libarchive and
libedit are long gone.
- Performance hit with one readelf execution per staged file
The costs are high for ports that stage many files. For
emulators/linux_base-rl9, the find returns over 30k hits that the while
loop must iterate over. It took about 15s for baselibs() to process
these files on an i7-10710U build system.
To fix these issues, use a filter similar to the one used by
proxydeps(). This way, only ELF objects are fed to one instance of
readelf, and the timing for baselibs() to process
emulators/linux_base-rl9 drops to about 1.5s.
PR: 296889
Sponsored by: The FreeBSD Foundation