netmap: Use ckdint.h helpers to check for overflow
Needs ReviewPublic
Actions

Authored by markj on Mon, Aug 17, 6:43 PM.

Tags

None

Referenced Files

	F167491717: D58896.id184212.diff
	Sat, Aug 22, 6:04 AM

	F167403763: D58896.diff
	Fri, Aug 21, 2:07 PM

	Unknown Object (File)
	Thu, Aug 20, 5:57 PM

	Unknown Object (File)
	Thu, Aug 20, 4:13 PM

	Unknown Object (File)
	Tue, Aug 18, 9:54 AM

	Unknown Object (File)
	Tue, Aug 18, 9:52 AM

	Unknown Object (File)
	Tue, Aug 18, 4:50 AM

Subscribers

imp

Details

Reviewers

vmaffione

Summary

This addresses a bug in the addition overflow check added in commit
319414a926af ("netmap: Handle overflow when computing ring sizes"): that
overflow wasn't actually caught by the check because "len" is promoted
to size_t.

Fixes: 319414a926af ("netmap: Handle overflow when computing ring sizes")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75656
Build 72539: arc lint + arc unit

Event Timeline

markj created this revision.Mon, Aug 17, 6:43 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Aug 17, 6:43 PM

markj requested review of this revision.Mon, Aug 17, 6:43 PM

Harbormaster completed remote builds in B75656: Diff 184212.Mon, Aug 17, 6:43 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

netmap/

netmap_mem2.c

10 lines

Diff 184212

View Options

sys/dev/netmap/netmap_mem2.c

netmap: Use ckdint.h helpers to check for overflowNeeds ReviewPublicActions