yes: Avoid static initialization
ClosedPublic
Actions

Authored by des on Mon, Aug 17, 2:14 PM.

Tags

None

Referenced Files

	F170601245: D58890.id184196.diff
	Sat, Sep 5, 2:29 PM

	F170575653: D58890.diff
	Sat, Sep 5, 11:44 AM

	Unknown Object (File)
	Fri, Sep 4, 8:37 AM

	Unknown Object (File)
	Fri, Sep 4, 3:52 AM

	Unknown Object (File)
	Fri, Sep 4, 12:22 AM

	Unknown Object (File)
	Thu, Sep 3, 11:40 AM

	Unknown Object (File)
	Wed, Sep 2, 9:05 PM

	Unknown Object (File)
	Wed, Sep 2, 7:29 PM

View All 43 Files

Subscribers

imp

Details

Reviewers

kevans

Group Reviewers

Klara

Commits

rG1e7d914ffcbe: yes: Avoid static initialization
rG557ba0c2a513: yes: Avoid static initialization

Summary

Our buffer is half a megabyte, but we are only initializing the first
two bytes. Switching from static to dynamic initialization moves it
from .data to .bss, greatly reducing the size of the binary.

Fixes: cf74b63d61b4 ("yes: Completely overengineer")
MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Mon, Aug 17, 2:14 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Aug 17, 2:14 PM

des requested review of this revision.Mon, Aug 17, 2:14 PM

Harbormaster completed remote builds in B75650: Diff 184196.Mon, Aug 17, 2:14 PM

kevans accepted this revision.Mon, Aug 17, 2:39 PM

This revision is now accepted and ready to land.Mon, Aug 17, 2:39 PM

Closed by commit rG557ba0c2a513: yes: Avoid static initialization (authored by des). · Explain WhyMon, Aug 17, 4:05 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG557ba0c2a513: yes: Avoid static initialization.

des added a commit: rG1e7d914ffcbe: yes: Avoid static initialization.Thu, Aug 27, 6:34 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

yes/

yes.c

10 lines

Diff 184200

View Options

yes: Avoid static initializationClosedPublicActions