Differential D58853

aq(4): arm PHY thermal shutdown only where a sensor exists
ClosedPublic
Actions

Authored by nick_spun.io on Sat, Aug 15, 2:30 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sun, Aug 16, 1:39 AM

	Unknown Object (File)
	Sun, Aug 16, 1:33 AM

	Unknown Object (File)
	Sat, Aug 15, 7:54 PM

	Unknown Object (File)
	Sat, Aug 15, 7:54 PM

Subscribers

Details

Reviewers

Commits

rG6dbf809bafe1: aq(4): arm PHY thermal shutdown only where a sensor exists

Summary

aq_fw2x_thermal_arm() reached for a copper PHY register that the fibre
parts do not implement, so arming failed on every init and printed a
warning for a capability the hardware cannot have. Return ENOTSUP when
the firmware does not advertise a temperature sensor, matching
aq_fw2x_get_temp(), and warn only for a genuine failure.

Signed-off-by: Nick Price <nprice@FreeBSD.org>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75599
Build 72482: arc lint + arc unit

Event Timeline

nick_spun.io created this revision.Sat, Aug 15, 2:30 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Aug 15, 2:30 AM

nick_spun.io requested review of this revision.Sat, Aug 15, 2:30 AM

Harbormaster completed remote builds in B75599: Diff 184083.Sat, Aug 15, 2:30 AM

nick_spun.io added a reviewer: adrian.Sat, Aug 15, 2:31 AM

nick_spun.io added a project: drivers.

adrian accepted this revision.Sat, Aug 15, 2:28 PM

This revision is now accepted and ready to land.Sat, Aug 15, 2:28 PM

nick_spun.io closed this revision.Sun, Aug 16, 7:23 PM

nick_spun.io added a commit: rG6dbf809bafe1: aq(4): arm PHY thermal shutdown only where a sensor exists.

Revision Contents
Changeset List

Path

Size

sys/

dev/

aq/

3 lines

10 lines

Diff 184083

sys/dev/aq/aq_fw2x.c

Loading...

sys/dev/aq/aq_main.c

Loading...