Page MenuHomeFreeBSD

multimedia/x264: modernize
ClosedPublic

Authored by jbeich on Apr 6 2016, 2:41 PM.

Details

Summary
  • Convert to option helpers
  • Convert to USES=localbase + respect CPPFLAGS
  • Convert to USES=shebangfix (users can select zsh)
  • Simplify SLAVE_PORT conditionals into ?=, += and !target()
  • Drop unnecessary cd before PGO sample
  • Drop no longer necessary .include <bsd.port.options.mk>
Test Plan

poudriere bulk -Ctj 101i386 multimedia/{lib,}x264 went fine

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich updated this revision to Diff 14930.Apr 6 2016, 2:41 PM
jbeich retitled this revision from to multimedia/x264: modernize.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: koobs.
jbeich updated this revision to Diff 14937.Apr 6 2016, 4:12 PM

Properly define OPTIONS_EXCLUDE in multimedia/libx264 to avoid duplicating OPTIONS_DEFINE.

jbeich updated this revision to Diff 14940.Apr 6 2016, 4:38 PM
  • Fix for Variable PGO_VARS is recursive.
  • Drop redundant DEBUG_CONFIGURE_OFF from libx264

With this my local PGO=on build with lang/gcc5 went fine. poudriere build for 10.1R i386 crashed with Bus error i.e., probably unrelated.

This revision was automatically updated to reflect the committed changes.