amd64 efirt: register all runtime regions as fictitious
ClosedPublic
Actions

Authored by kib on Thu, Jul 16, 6:52 AM.

Details

Reviewers

Commits

rGa2f50c4b32d1: amd64 efirt: register all runtime regions as fictitious

Summary

This is needed for VM_PHYS_TO_PAGE() to work, which is needed for
pmap_map_io_transient() to work, which is needed for uiomove_fromphys()
to work.

PR:     296348
Reported and tested: Anton Saietskii <vsasjason@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Thu, Jul 16, 6:52 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jul 16, 6:52 AM

kib requested review of this revision.Thu, Jul 16, 6:52 AM

kib edited the summary of this revision. (Show Details)Thu, Jul 16, 12:54 PM

kib added a reviewer: markj.

markj accepted this revision.Thu, Jul 16, 2:03 PM

markj added inline comments.

sys/amd64/amd64/efirt_machdep.c
258	Should we check for and report an error?

This revision is now accepted and ready to land.Thu, Jul 16, 2:03 PM

kib marked an inline comment as done.Thu, Jul 16, 2:29 PM

kib added inline comments.

sys/amd64/amd64/efirt_machdep.c
258	I do not see much use for it. We did not registered so far at all. The error could only occur if the range covers vm_page_array[] from 'both sides', which cannot happen on x86 at all. I just added the (void) cast to the call.