Paths

Table of Contentst

Differential D58042

ibcore: Fix GID sysctl fallback formatting
ClosedPublic
Actions

Authored by slavash on Sun, Jul 5, 8:15 AM.

Tags

None

Referenced Files

	F162820089: D58042.id181304.diff
	Fri, Jul 17, 5:46 AM

	F162799885: D58042.id181328.diff
	Fri, Jul 17, 1:06 AM

	F162776462: D58042.id.diff
	Thu, Jul 16, 6:47 PM

	Unknown Object (File)
	Wed, Jul 15, 7:29 AM

	Unknown Object (File)
	Wed, Jul 15, 7:29 AM

	Unknown Object (File)
	Wed, Jul 15, 6:01 AM

	Unknown Object (File)
	Wed, Jul 15, 12:57 AM

	Unknown Object (File)
	Sun, Jul 12, 2:20 PM

View All 19 Files

Subscribers

Details

Reviewers

jhb
kib

Commits

rGb125b736eaf7: ibcore: Fix GID sysctl fallback formatting

Summary

When a GID table entry is empty or not yet present in the cache,
show_port_gid() falls back to printing a zero GID. Use the existing
GID_PRINT_FMT/GID_PRINT_ARGS helpers instead of Linux's %pI6 format,
which FreeBSD printf treats as a pointer followed by "I6".
This makes empty GID sysctl entries consistently report
0000:0000:0000:0000:0000:0000:0000:0000.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

slavash created this revision.Sun, Jul 5, 8:15 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Jul 5, 8:15 AM

slavash requested review of this revision.Sun, Jul 5, 8:15 AM

kib accepted this revision.Sun, Jul 5, 8:35 AM

This revision is now accepted and ready to land.Sun, Jul 5, 8:35 AM

Please pass the -U999999 argument to the git diff command you used to generate the uploaded patch, for the next time.

Oops, I must have missed this when merging. Thanks!

Closed by commit rGb125b736eaf7: ibcore: Fix GID sysctl fallback formatting (authored by slavash, committed by kib). · Explain WhyMon, Jul 6, 10:18 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGb125b736eaf7: ibcore: Fix GID sysctl fallback formatting.

Revision Contents
Changeset List

Path

Size

sys/

ofed/

drivers/

infiniband/

core/

2 lines

Diff 181328

sys/ofed/drivers/infiniband/core/ib_sysfs.c

Loading...