Paths

Table of Contentst

Differential D58042

ibcore: Fix GID sysctl fallback formatting
ClosedPublic
Actions

Authored by slavash on Jul 5 2026, 8:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 12, 11:53 PM

	Unknown Object (File)
	Wed, Aug 12, 1:04 AM

	Unknown Object (File)
	Tue, Aug 11, 4:25 PM

	Unknown Object (File)
	Mon, Aug 10, 12:21 PM

	Unknown Object (File)
	Mon, Aug 10, 11:41 AM

	Unknown Object (File)
	Mon, Aug 10, 10:12 AM

	Unknown Object (File)
	Mon, Aug 10, 2:21 AM

	Unknown Object (File)
	Sun, Aug 9, 11:04 AM

View All 43 Files

Subscribers

Details

Reviewers

jhb
kib

Commits

rGb125b736eaf7: ibcore: Fix GID sysctl fallback formatting

Summary

When a GID table entry is empty or not yet present in the cache,
show_port_gid() falls back to printing a zero GID. Use the existing
GID_PRINT_FMT/GID_PRINT_ARGS helpers instead of Linux's %pI6 format,
which FreeBSD printf treats as a pointer followed by "I6".
This makes empty GID sysctl entries consistently report
0000:0000:0000:0000:0000:0000:0000:0000.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

slavash created this revision.Jul 5 2026, 8:15 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 5 2026, 8:15 AM

slavash requested review of this revision.Jul 5 2026, 8:15 AM

kib accepted this revision.Jul 5 2026, 8:35 AM

This revision is now accepted and ready to land.Jul 5 2026, 8:35 AM

Please pass the -U999999 argument to the git diff command you used to generate the uploaded patch, for the next time.

Oops, I must have missed this when merging. Thanks!

Closed by commit rGb125b736eaf7: ibcore: Fix GID sysctl fallback formatting (authored by slavash, committed by kib). · Explain WhyJul 6 2026, 10:18 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGb125b736eaf7: ibcore: Fix GID sysctl fallback formatting.

Revision Contents
Changeset List

Path

Size

sys/

ofed/

drivers/

infiniband/

core/

2 lines

Diff 181328

sys/ofed/drivers/infiniband/core/ib_sysfs.c

Loading...