Details
Details
- Reviewers
markj fuz - Commits
- R11:8b18be2a43b1: devel/freebsd-git-mfc: New port
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| devel/freebsd-git-mfc/Makefile | ||
|---|---|---|
| 5–6 | Not a huge fan of this as it goes against the rules of using USE_GITHUB for this sort of stuff, but given the large size of the system sources it might make sense. Also consider having the script live in /usr/ports/devel/freebsd-git-mfc/files instead so we don't need to fetch it at all. | |
| 30 | Might be easier to just have EXTRACT_ONLY= instead of a do-extract target. Then copy the files directly from _DISTDIR in do-install. | |
| 33 | (if the previous suggestion is not taken) | |
| devel/freebsd-git-mfc/Makefile | ||
|---|---|---|
| 30 | No, this port has a build stage, the script needs to transit through ${WRKSRC}. | |
| devel/freebsd-git-mfc/Makefile | ||
|---|---|---|
| 30 | It does not have a build stage, you set NO_BUILD=yes. | |
| devel/freebsd-git-mfc/Makefile | ||
|---|---|---|
| 30 | Sorry, I meant it has a patch stage. | |
Comment Actions
LGTM, but please consider the _DISTDIR change.
| devel/freebsd-git-mfc/Makefile | ||
|---|---|---|
| 30 | Right, that makes sense (for shebangfix). Very well then. | |